From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/i915: extract fixed point math to i915_fixed.h
Date: Fri, 16 Nov 2018 12:52:51 +0200 [thread overview]
Message-ID: <87efblgupo.fsf@intel.com> (raw)
In-Reply-To: <154236460490.10902.437789377343629830@jlahtine-desk.ger.corp.intel.com>
On Fri, 16 Nov 2018, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2018-11-15 14:01:22)
>> Reduce bloat in one of the bigger header files. Fix some indentation
>> while at it. No functional changes.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Do add include guards. Then this is:
D'oh!
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Thanks for the review.
BR,
Jani.
>
> Regards, Joonas
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-11-16 10:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:01 [PATCH 1/5] drm/i915: extract fixed point math to i915_fixed.h Jani Nikula
2018-11-15 12:01 ` [PATCH 2/5] drm/i915/fixed: prefer kernel types over stdint types Jani Nikula
2018-11-16 10:38 ` Joonas Lahtinen
2018-11-15 12:01 ` [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition Jani Nikula
2018-11-16 10:40 ` Joonas Lahtinen
2018-11-16 10:54 ` Jani Nikula
2018-11-16 10:52 ` Chris Wilson
2018-11-20 11:12 ` Jani Nikula
2018-11-15 12:01 ` [PATCH 4/5] drm/i915/fixed: simplify is_fixed16_zero() Jani Nikula
2018-11-16 10:40 ` Joonas Lahtinen
2018-11-15 12:01 ` [PATCH 5/5] drm/i915/fixed: cosmetic cleanup Jani Nikula
2018-11-16 10:56 ` Joonas Lahtinen
2018-11-15 12:57 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h Patchwork
2018-11-15 13:00 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-15 13:14 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-15 15:55 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-16 10:36 ` [PATCH 1/5] " Joonas Lahtinen
2018-11-16 10:52 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efblgupo.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox