Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Cc: Tvrtko Ursulin <tursulin@ursulin.net>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>
Subject: Re: [PATCH 0/2] Trivial double space style fix
Date: Wed, 07 Aug 2024 16:08:27 +0300	[thread overview]
Message-ID: <87frrg4h10.fsf@intel.com> (raw)
In-Reply-To: <20240807130516.491053-1-andi.shyti@linux.intel.com>

On Wed, 07 Aug 2024, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi,
>
> I was bothered a few times to see the double space in the
> parameters list so that I decided to replace once and for all all
> the double spaces that are not added on purpose to maintain some
> visual alignment in the code.
>
> Checkpatch doesn't have any rules for that because, indeed, this
> is used also to put in columns parameters in repetitive function
> calls or declarations. Nevertheless, it doesn't mean it's
> stylistically correct.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Thanks,
> Andi
>
> Andi Shyti (2):
>   drm/i915: Replace double blank with single blank after comma in gem/ and gt/
>   drm/i915: Replace double blank with single blank after comma
>
>  drivers/gpu/drm/i915/display/i9xx_wm.c               | 2 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c             | 2 +-
>  drivers/gpu/drm/i915/display/intel_display.c         | 2 +-
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_dp_hdcp.c         | 2 +-
>  drivers/gpu/drm/i915/gem/i915_gem_object_types.h     | 2 +-
>  drivers/gpu/drm/i915/gt/selftest_migrate.c           | 2 +-
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c                | 2 +-
>  drivers/gpu/drm/i915/gvt/trace.h                     | 2 +-
>  drivers/gpu/drm/i915/i915_driver.c                   | 6 +++---
>  drivers/gpu/drm/i915/i915_sysfs.c                    | 4 ++--
>  drivers/gpu/drm/i915/selftests/intel_memory_region.c | 2 +-
>  12 files changed, 15 insertions(+), 15 deletions(-)

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2024-08-07 13:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 13:05 [PATCH 0/2] Trivial double space style fix Andi Shyti
2024-08-07 13:05 ` [PATCH 1/2] drm/i915: Replace double blank with single blank after comma in gem/ and gt/ Andi Shyti
2024-08-07 13:05 ` [PATCH 2/2] drm/i915: Replace double blank with single blank after comma Andi Shyti
2024-08-07 13:08 ` Jani Nikula [this message]
2024-08-07 13:35 ` ✗ Fi.CI.CHECKPATCH: warning for Trivial double space style fix Patchwork
2024-08-07 13:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-08-07 13:48 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-08-07 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for Trivial double space style fix (rev2) Patchwork
2024-08-07 14:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-08-07 14:37 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-08-07 16:05 ` ✗ Fi.CI.CHECKPATCH: warning for Trivial double space style fix (rev3) Patchwork
2024-08-07 16:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-08-07 16:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-08  6:19 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frrg4h10.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=krzysztof.niemiec@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox