public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained
Date: Tue, 25 Jun 2019 12:29:23 +0300	[thread overview]
Message-ID: <87ftnyrp1o.fsf@intel.com> (raw)
In-Reply-To: <op.z3i9yfupxaggs7@mwajdecz-mobl1.ger.corp.intel.com>

On Mon, 17 Jun 2019, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> On Mon, 17 Jun 2019 11:51:05 +0200, Jani Nikula <jani.nikula@intel.com>  
> wrote:
>
>> Add the minimal includes/declarations to make the header self-contained,
>> and ensure it stays that way.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/Makefile.header-test | 1 +
>>  drivers/gpu/drm/i915/intel_guc_reg.h      | 3 +++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/Makefile.header-test  
>> b/drivers/gpu/drm/i915/Makefile.header-test
>> index b140afeb617e..085fba8e71f2 100644
>> --- a/drivers/gpu/drm/i915/Makefile.header-test
>> +++ b/drivers/gpu/drm/i915/Makefile.header-test
>> @@ -22,6 +22,7 @@ header_test := \
>>  	intel_drv.h \
>>  	intel_guc_ct.h \
>>  	intel_guc_fwif.h \
>> +	intel_guc_reg.h \
>>  	intel_pm.h \
>>  	intel_runtime_pm.h \
>>  	intel_sideband.h \
>> diff --git a/drivers/gpu/drm/i915/intel_guc_reg.h  
>> b/drivers/gpu/drm/i915/intel_guc_reg.h
>> index a214f8b71929..02f4b1d61a98 100644
>> --- a/drivers/gpu/drm/i915/intel_guc_reg.h
>> +++ b/drivers/gpu/drm/i915/intel_guc_reg.h
>> @@ -24,6 +24,9 @@
>>  #ifndef _INTEL_GUC_REG_H_
>>  #define _INTEL_GUC_REG_H_
>> +#include <linux/compiler.h>
>> +#include <linux/types.h>
>> +
>>  /* Definitions of GuC H/W registers, bits, etc */
>> #define GUC_STATUS			_MMIO(0xc000)
>
> shouldn't we also include i915_reg.h for _MMIO definition?

Thanks, added that in v2. Though this compiles just fine standalone when
nobody uses the macros. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-25  9:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17  9:50 drm/i915: last bits to make headers self-contained Jani Nikula
2019-06-17  9:50 ` [PATCH 01/11] drm/i915: make i915_fixed.h self-contained Jani Nikula
2019-06-17  9:50 ` [PATCH 02/11] drm/i915: make i915_gem_gtt.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 03/11] drm/i915: make i915_globals.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 04/11] drm/i915: make i915_pvinfo.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 05/11] drm/i915: make i915_vgpu.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 06/11] drm/i915: make intel_guc_ct.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 07/11] drm/i915: make intel_guc_fwif.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained Jani Nikula
2019-06-17 14:45   ` Michal Wajdeczko
2019-06-25  9:29     ` Jani Nikula [this message]
2019-06-17  9:51 ` [PATCH 09/11] drm/i915: make intel_gvt.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 10/11] drm/i915: make intel_uc_fw.h self-contained Jani Nikula
2019-06-17  9:51 ` [PATCH 11/11] drm/i915: use wildcard to ensure all headers stay self-contained Jani Nikula
2019-06-17 12:15 ` drm/i915: last bits to make headers self-contained Chris Wilson
2019-06-17 15:41 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/11] drm/i915: make i915_fixed.h self-contained Patchwork
2019-06-17 16:18 ` ✓ Fi.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftnyrp1o.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox