From: Jani Nikula <jani.nikula@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [RFC 1/4] drm/i915: Add Display Gen info.
Date: Wed, 31 Oct 2018 11:00:54 +0200 [thread overview]
Message-ID: <87ftwmmqwp.fsf@intel.com> (raw)
In-Reply-To: <83eb34c4-0549-76d3-1692-cd0e4d39e810@linux.intel.com>
On Wed, 31 Oct 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> I saw some mention somewhere on IS_GEN_RANGE, which looked clearer than
> IS_GEN(dev_priv, s, e). Presumably that did not go anywhere since now
> the proposal is the above? I have to say I am not sure it reads
> completely intuitive when seen near in code:
>
> IS_GEN(dev_priv, 9)
> IS_GEN(dev_priv, 8, 9)
>
> Looks like a variable arg list and the difference in semantics does not
> come through. As such I am leaning towards thinking it is too much churn
> for unclear benefit. Or in other words I thought IS_GEN_RANGE was a
> better direction.
Okay, thanks for the feedback. I'm not locked into any resolution yet,
apart from not churning anything until we have a better picture where
we're going.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-31 9:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 0:34 [RFC 1/4] drm/i915: Add Display Gen info Rodrigo Vivi
2018-10-30 0:34 ` [RFC 2/4] drm/i915: Finally recognize Geminilake as Gen10 Display Rodrigo Vivi
2018-10-30 0:34 ` [RFC 3/4] drm/i915: Use Display gen9 for gen9_bc || bxt Rodrigo Vivi
2018-10-30 0:34 ` [RFC 4/4] drm/i915: Expand DISPLAY_GEN macro usage to display related files Rodrigo Vivi
2018-10-30 1:19 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/4] drm/i915: Add Display Gen info Patchwork
2018-10-30 1:21 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-10-30 1:39 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-30 9:52 ` [RFC 1/4] " Jani Nikula
2018-10-30 17:47 ` Rodrigo Vivi
2018-10-30 18:25 ` Lucas De Marchi
2018-10-31 8:13 ` Jani Nikula
2018-10-31 8:44 ` Tvrtko Ursulin
2018-10-31 9:00 ` Jani Nikula [this message]
2018-10-31 15:53 ` Rodrigo Vivi
2018-10-31 17:55 ` Jani Nikula
2018-10-31 18:13 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftwmmqwp.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox