From: Jani Nikula <jani.nikula@intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] drm: split build lists one per line and sort
Date: Wed, 12 Oct 2022 17:05:39 +0300 [thread overview]
Message-ID: <87h709w30s.fsf@intel.com> (raw)
In-Reply-To: <20221012131043.teqj46p6dpi4opil@houat>
On Wed, 12 Oct 2022, Maxime Ripard <maxime@cerno.tech> wrote:
> On Wed, Oct 12, 2022 at 03:32:32PM +0300, Jani Nikula wrote:
>> On Tue, 11 Oct 2022, Jani Nikula <jani.nikula@intel.com> wrote:
>> > While it takes more vertical space, sorted build lists with one object
>> > per line are arguably easier to manage, especially when there are
>> > conflicting changes.
>> >
>> > Split anything with more than one object file.
>> >
>> > v2: also split drm_cache.o and put it after drm_bridge.o (Andi)
>> >
>> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>>
>> Cc: drm-misc maintainers, don't really want to push this without an
>> approval from you guys.
>
> Acked-by: Maxime Ripard <maxime@cerno.tech>
>
> Thanks for doing this
Thanks, pushed to drm-misc-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2022-10-12 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 14:08 [Intel-gfx] [PATCH v2] drm: split build lists one per line and sort Jani Nikula
2022-10-11 17:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: split build lists one per line and sort (rev2) Patchwork
2022-10-11 21:27 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-12 12:32 ` [Intel-gfx] [PATCH v2] drm: split build lists one per line and sort Jani Nikula
2022-10-12 13:10 ` Maxime Ripard
2022-10-12 14:05 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h709w30s.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maxime@cerno.tech \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox