Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel: Add support for (possibly) unsynchronized maps.
Date: Mon, 27 Feb 2012 11:05:32 -0800	[thread overview]
Message-ID: <87haycjdvn.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20120225110007.GA4222@phenom.ffwll.local>


[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]

On Sat, 25 Feb 2012 12:00:07 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Feb 24, 2012 at 07:53:22PM -0800, Eric Anholt wrote:
> > This improves the performance of Mesa's GL_MAP_UNSYNCHRONIZED_BIT path
> > in GL_ARB_map_buffer_range.  Improves Unigine Tropics performance at
> > 1024x768 by 2.06236% +/- 0.50272% (n=11).
> > ---
> 
> A few questions:
> - iirc Ben's non-blocking stuff also worked for non-llc machines - I guess
>   you haven't looked into this because we don't have a non-llc platform
>   that runs ungine?

I gave up on Ben's non-blocking stuff for being way too many patches all
smashed into one.  I wanted a simple fix that could be extended later if
other apps have other problems, while completely fixing this app (a
~21ms wait shortly after starting a new frame).

> - in my pwrite experience, writing through cpu maps beats writing through
>   the gtt on llc machines. This has the added benefit that it reduces
>   pressure on the mappable gtt. Have you tried that, too?

I haven't played with that, but it would be fun to at some point once we
get there.  Right now, the CPU overhead of the app isn't in this path.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2012-02-27 19:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25  3:53 [PATCH] intel: Add support for (possibly) unsynchronized maps Eric Anholt
2012-02-25  3:53 ` [PATCH] intel: Make use of the new GPU-unsynchronized map functionality in libdrm Eric Anholt
2012-02-25  8:55 ` [PATCH] intel: Add support for (possibly) unsynchronized maps Chris Wilson
2012-02-25  9:03 ` Paul Menzel
2012-02-25 11:00 ` Daniel Vetter
2012-02-25 11:16   ` Chris Wilson
2012-02-26 20:28   ` Kenneth Graunke
2012-02-27 11:15     ` Ben Widawsky
2012-02-27 19:05   ` Eric Anholt [this message]
2012-02-28  7:35 ` [PATCH 1/2] intel: Fix error check for I915_PARAM_HAS_LLC Eric Anholt
2012-02-28  7:35   ` [PATCH 2/2] intel: Add support for (possibly) unsynchronized maps Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haycjdvn.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox