Re: [Intel-gfx] [PATCH] drm/i915/dmc: Change DMC FW size on ADL-P

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 06 Dec 2021, Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com> wrote:
> Increase the size of DMC on ADL-P to account for support of
> new features in the current/upcoming DMC versions.
>
> Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dmc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 2dc9d632969d..0cab18f972d1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -45,6 +45,8 @@
>  
>  #define GEN12_DMC_MAX_FW_SIZE		ICL_DMC_MAX_FW_SIZE
>  
> +#define GEN13_DMC_MAX_FW_SIZE		0x20000
> +

Side note, we should get rid of these GEN<N> references here.


>  #define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 12)
>  #define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 12)
>  MODULE_FIRMWARE(ADLP_DMC_PATH);
> @@ -682,7 +684,7 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
>  	if (IS_ALDERLAKE_P(dev_priv)) {
>  		dmc->fw_path = ADLP_DMC_PATH;
>  		dmc->required_version = ADLP_DMC_VERSION_REQUIRED;
> -		dmc->max_fw_size = GEN12_DMC_MAX_FW_SIZE;
> +		dmc->max_fw_size = GEN13_DMC_MAX_FW_SIZE;
>  	} else if (IS_ALDERLAKE_S(dev_priv)) {
>  		dmc->fw_path = ADLS_DMC_PATH;
>  		dmc->required_version = ADLS_DMC_VERSION_REQUIRED;

-- 
Jani Nikula, Intel Open Source Graphics Center