From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt
Date: Tue, 31 Mar 2020 16:07:44 +0300 [thread overview]
Message-ID: <87imikpt9b.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200331091459.29179-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Since we don't wait for the error interrupt to reset, restart and then
> complete the guilty request, clean up the error messages.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index d3e163c93e22..b929e52a8f5a 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -649,9 +649,9 @@ static int live_error_interrupt(void *arg)
> error_repr(p->error[i]));
>
> if (!i915_request_started(client[i])) {
> - pr_debug("%s: %s request not stated!\n",
> - engine->name,
> - error_repr(p->error[i]));
> + pr_err("%s: %s request not started!\n",
> + engine->name,
> + error_repr(p->error[i]));
> err = -ETIME;
> goto out;
> }
> @@ -659,9 +659,10 @@ static int live_error_interrupt(void *arg)
> /* Kick the tasklet to process the error */
> intel_engine_flush_submission(engine);
> if (client[i]->fence.error != p->error[i]) {
> - pr_err("%s: %s request completed with wrong error code: %d\n",
> + pr_err("%s: %s request (%s) with wrong error code: %d\n",
> engine->name,
> error_repr(p->error[i]),
> + i915_request_completed(client[i]) ? "completed" : "running",
> client[i]->fence.error);
> err = -EINVAL;
> goto out;
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-31 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 9:14 [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt Chris Wilson
2020-03-31 9:14 ` [Intel-gfx] [PATCH 2/4] drm/i915/execlists: Pause CS flow before reset Chris Wilson
2020-03-31 13:08 ` Mika Kuoppala
2020-03-31 9:14 ` [Intel-gfx] [PATCH 3/4] drm/i915/execlists: Peek at the next submission for error interrupts Chris Wilson
2020-03-31 9:14 ` [Intel-gfx] [PATCH 4/4] drm/i915/execlists: Record the active CCID from before reset Chris Wilson
2020-03-31 11:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt Patchwork
2020-03-31 13:07 ` Mika Kuoppala [this message]
2020-04-01 8:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imikpt9b.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox