From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/debugfs: also take per device driver features into account
Date: Sat, 25 Jan 2020 16:07:22 +0200 [thread overview]
Message-ID: <87imkzd3z9.fsf@intel.com> (raw)
In-Reply-To: <6aa5cab2-6d5f-1a9e-6e04-261ef3476fdb@suse.de>
On Thu, 23 Jan 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 23.01.20 um 13:48 schrieb Jani Nikula:
>> Use drm_core_check_all_features() to ensure both the driver features and
>> the per-device driver features are taken into account when registering
>> debugfs files.
>>
>> v3:
>> - files[i].driver_features == 0 actually means "don't care"
>>
>> v2:
>> - use drm_core_check_all_features()
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/drm_debugfs.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
>> index eab0f2687cd6..4e673d318503 100644
>> --- a/drivers/gpu/drm/drm_debugfs.c
>> +++ b/drivers/gpu/drm/drm_debugfs.c
>> @@ -182,8 +182,7 @@ int drm_debugfs_create_files(const struct drm_info_list *files, int count,
>> for (i = 0; i < count; i++) {
>> u32 features = files[i].driver_features;
>>
>> - if (features != 0 &&
>> - (dev->driver->driver_features & features) != features)
>> + if (features && !drm_core_check_all_features(dev, features))
>> continue;
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks for the review, both pushed to drm-misc-next.
BR,
Jani.
>
>>
>> tmp = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-25 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 12:48 [Intel-gfx] [PATCH v4 1/2] drm: add drm_core_check_all_features() to check for a mask of features Jani Nikula
2020-01-23 12:48 ` [Intel-gfx] [PATCH v4 2/2] drm/debugfs: also take per device driver features into account Jani Nikula
2020-01-23 14:06 ` Thomas Zimmermann
2020-01-25 14:07 ` Jani Nikula [this message]
2020-01-23 21:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm: add drm_core_check_all_features() to check for a mask of features Patchwork
2020-01-25 10:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imkzd3z9.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox