From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, "Souza\,
Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
martin.peres@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix an error code in intel_modeset_all_tiles()
Date: Thu, 09 Jan 2020 13:17:08 +0200 [thread overview]
Message-ID: <87imlkq3pn.fsf@intel.com> (raw)
In-Reply-To: <157849428827.2273.15167701436088595576@skylake-alporthouse-com>
On Wed, 08 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-01-08 14:33:22)
>> On Tue, 07 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Quoting Souza, Jose (2020-01-07 14:01:40)
>> >> On Tue, 2020-01-07 at 16:03 +0300, Dan Carpenter wrote:
>> >> > There is a cut and paste bug so we return the wrong error code.
>> >> >
>> >> > Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get
>> >> > added to the state with full modeset")
>> >>
>> >> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>> >>
>> >> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> >
>> > Pushed. Thanks for the patch,
>>
>> Hrmh, we are still supposed to wait for CI results for every patch, no
>> exceptions.
>
> There is no coverage of that path in CI.
Maybe not, but making that assessment is not obvious to me.
I don't want to start on the slippery slope of people pushing untested
patches claiming "no coverage".
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-09 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:03 [Intel-gfx] [PATCH] drm/i915: fix an error code in intel_modeset_all_tiles() Dan Carpenter
2020-01-07 14:01 ` Souza, Jose
2020-01-07 14:05 ` Chris Wilson
2020-01-08 14:33 ` Jani Nikula
2020-01-08 14:38 ` Chris Wilson
2020-01-09 11:17 ` Jani Nikula [this message]
2020-01-07 16:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imlkq3pn.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox