Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
Date: Thu, 08 Nov 2018 17:11:45 +0200	[thread overview]
Message-ID: <87in17hadq.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20181108140039.12254-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> We have multiple instances of VCS but only remember to invalidate the
> BSD caches on the first, ignoring the stale caches of any other engine.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Missing this prolly would have caused much hair pulling in future, so
nice catch.

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Lets flush also the LLC for gen9+ on followup patch?
-Mika

> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index f7892ddb3f13..08fd9b12e4d7 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1956,7 +1956,7 @@ static int gen8_emit_flush(struct i915_request *request, u32 mode)
>  
>  	if (mode & EMIT_INVALIDATE) {
>  		cmd |= MI_INVALIDATE_TLB;
> -		if (request->engine->id == VCS)
> +		if (request->engine->class == VIDEO_DECODE_CLASS)
>  			cmd |= MI_INVALIDATE_BSD;
>  	}
>  
> -- 
> 2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-11-08 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 14:00 [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines Chris Wilson
2018-11-08 14:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-08 15:11 ` Mika Kuoppala [this message]
2018-11-08 22:32 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in17hadq.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox