Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Patchwork <patchwork@emeril.freedesktop.org>,
	Vidya Srinivas <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for Add NV12 support (rev4)
Date: Mon, 26 Mar 2018 16:48:41 +0300	[thread overview]
Message-ID: <87in9jeyme.fsf@intel.com> (raw)
In-Reply-To: <20180326052321.6919.52790@emeril.freedesktop.org>

On Mon, 26 Mar 2018, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: Add NV12 support (rev4)
> URL   : https://patchwork.freedesktop.org/series/39670/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> 0503b1db737a drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
> de530aafc1d7 drm/i915/skl+: refactor WM calculation for NV12
> 7ca6efaada2b drm/i915/skl+: add NV12 in skl_format_to_fourcc
> 4863044b11a5 drm/i915/skl+: support verification of DDB HW state for NV12
> 4c4d4f07274c drm/i915/skl+: NV12 related changes for WM
> 1995882fa722 drm/i915/skl+: pass skl_wm_level struct to wm compute func
> 7a53eb021631 drm/i915/skl+: make sure higher latency level has higher wm value
> b756f5e1b974 drm/i915/skl+: nv12 workaround disable WM level 1-7
> 2f6264f9349f drm/i915/skl: split skl_compute_ddb function
> -:137: CHECK:SPACING: spaces preferred around that '*' (ctx:ExV)
> #137: FILE: drivers/gpu/drm/i915/intel_pm.c:5160:
> +		*changed = true;
>  		^

Checkpatch being clueless.

>
> total: 0 errors, 0 warnings, 1 checks, 194 lines checked
> d87f6cf26fea drm/i915: Set scaler mode for NV12
> ccc7a37f5e0a drm/i915: Update format_is_yuv() to include NV12
> 17490b4ce656 drm/i915: Upscale scaler max scale for NV12
> e155048376b9 drm/i915: Add NV12 as supported format for primary plane
> d7af95f5e1d4 drm/i915: Add NV12 as supported format for sprite plane
> 483020f92c69 drm/i915: Add NV12 support to intel_framebuffer_init
> 4ca02e5f9bd0 drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg
> a7f9ce556ab2 drm/i915: Display WA 827
> 545fe6ed4604 drm/i915: Add checks to primary plane
> -:108: CHECK:SPACING: No space is necessary after a cast
> #108: FILE: drivers/gpu/drm/i915/intel_display.c:13052:
> +		WARN_ON(src->x1 < (int) state->base.src_x ||
>
> -:109: CHECK:SPACING: No space is necessary after a cast
> #109: FILE: drivers/gpu/drm/i915/intel_display.c:13053:
> +			src->y1 < (int) state->base.src_y ||
>
> -:110: CHECK:SPACING: No space is necessary after a cast
> #110: FILE: drivers/gpu/drm/i915/intel_display.c:13054:
> +			src->x2 > (int) state->base.src_x + state->base.src_w ||
>
> -:111: CHECK:SPACING: No space is necessary after a cast
> #111: FILE: drivers/gpu/drm/i915/intel_display.c:13055:
> +			src->y2 > (int) state->base.src_y + state->base.src_h);
>

I don't mind the spaces after a cast; sadly SPACING category is not
something I'm willing to ignore completely.

> -:148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #148: FILE: drivers/gpu/drm/i915/intel_display.c:13092:
> +		if (INTEL_GEN(dev_priv) < 9 && (src_w > 2048 || src_h > 2048 ||
> +		    width_bytes > 4096 || fb->pitches[0] > 4096)) {

Pedantically a valid warning, but can be ignored in favor of getting the
series finally merged.

BR,
Jani.

>
> total: 0 errors, 0 warnings, 5 checks, 148 lines checked
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-03-26 13:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26  5:13 [PATCH v16 00/18] Add NV12 support Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 01/18] drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 02/18] drm/i915/skl+: refactor WM calculation for NV12 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 03/18] drm/i915/skl+: add NV12 in skl_format_to_fourcc Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 04/18] drm/i915/skl+: support verification of DDB HW state for NV12 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 05/18] drm/i915/skl+: NV12 related changes for WM Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 06/18] drm/i915/skl+: pass skl_wm_level struct to wm compute func Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 07/18] drm/i915/skl+: make sure higher latency level has higher wm value Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 08/18] drm/i915/skl+: nv12 workaround disable WM level 1-7 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 09/18] drm/i915/skl: split skl_compute_ddb function Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 10/18] drm/i915: Set scaler mode for NV12 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 11/18] drm/i915: Update format_is_yuv() to include NV12 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 12/18] drm/i915: Upscale scaler max scale for NV12 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 13/18] drm/i915: Add NV12 as supported format for primary plane Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 14/18] drm/i915: Add NV12 as supported format for sprite plane Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 15/18] drm/i915: Add NV12 support to intel_framebuffer_init Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 16/18] drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 17/18] drm/i915: Display WA 827 Vidya Srinivas
2018-03-26  5:13 ` [PATCH v16 18/18] drm/i915: Add checks to primary plane Vidya Srinivas
2018-03-26  5:23 ` ✗ Fi.CI.CHECKPATCH: warning for Add NV12 support (rev4) Patchwork
2018-03-26 13:48   ` Jani Nikula [this message]
2018-03-27  2:40     ` Srinivas, Vidya
2018-03-26  5:40 ` ✓ Fi.CI.BAT: success " Patchwork
2018-03-26  6:24 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in9jeyme.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=patchwork@emeril.freedesktop.org \
    --cc=vidya.srinivas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox