Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915: Include the global reset count for intel_engine_dump()
Date: Wed, 22 Nov 2017 11:50:30 +0200	[thread overview]
Message-ID: <87ine24p7d.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171121093941.15459-5-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Since a global reset affects the engine, include that along side the
> per-engine reset counter when pretty printing the engine state in
> intel_engine_dump().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_engine_cs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index aa490120749a..2ab18eb10d52 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1679,8 +1679,9 @@ void intel_engine_dump(struct intel_engine_cs *engine,
>  		   engine->hangcheck.seqno,
>  		   jiffies_to_msecs(jiffies - engine->hangcheck.action_timestamp),
>  		   engine->timeline->inflight_seqnos);
> -	drm_printf(m, "\tReset count: %d\n",
> -		   i915_reset_engine_count(error, engine));
> +	drm_printf(m, "\tReset count: %d (global %d)\n",
> +		   i915_reset_engine_count(error, engine),
> +		   i915_reset_count(error));
>  
>  	rcu_read_lock();
>  
> -- 
> 2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-22  9:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21  9:39 [PATCH 1/6] drm/printer: Add drm_vprintf() Chris Wilson
2017-11-21  9:39 ` [PATCH 2/6] drm/i915: Use snprintf to avoid line-break when pretty-printing engines Chris Wilson
2017-11-22  9:12   ` Mika Kuoppala
2017-11-21  9:39 ` [PATCH 3/6] drm/i915: Make engine state pretty-printer header configurable Chris Wilson
2017-11-21  9:39 ` [PATCH 4/6] drm/i915: Include engine state on detecting a missed breadcrumb/seqno Chris Wilson
2017-11-22  9:29   ` Mika Kuoppala
2017-11-21  9:39 ` [PATCH 5/6] drm/i915: Include the global reset count for intel_engine_dump() Chris Wilson
2017-11-22  9:50   ` Mika Kuoppala [this message]
2017-11-21  9:39 ` [PATCH 6/6] drm/i915: Add is-wedged flag to intel_engine_dump() Chris Wilson
2017-11-21 10:13 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/printer: Add drm_vprintf() Patchwork
2017-11-21 10:57 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-21 11:21 ` [PATCH v2] " Chris Wilson
2017-11-21 12:04   ` Michal Wajdeczko
2017-11-21 12:25     ` Chris Wilson
2017-11-21 13:07 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm/printer: Add drm_vprintf() (rev2) Patchwork
2017-11-21 14:50 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-22 10:55 ` [PATCH v3] drm/printer: Add drm_vprintf() Chris Wilson
2017-11-22 11:20 ` ✓ Fi.CI.BAT: success for series starting with [v3] drm/printer: Add drm_vprintf() (rev3) Patchwork
2017-11-22 14:28 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ine24p7d.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox