From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove pre-production pooled-EU w/a for Broxton
Date: Fri, 17 Nov 2017 12:04:00 +0200 [thread overview]
Message-ID: <87ine95ii7.fsf@intel.com> (raw)
In-Reply-To: <151091278045.26104.5386889197074789371@mail.alporthouse.com>
On Fri, 17 Nov 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> That seems like a reasonably policy.
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 57dfaf04d819..0be79cf993fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -833,6 +833,11 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
> * We don't keep the workarounds for pre-production hardware, so we expect our
> * driver to fail on these machines in one way or another. A little warning on
> * dmesg may help both the user and the bug triagers.
> + *
> + * Our policy for removing workarounds is to keep the current gen workarounds
> + * as a guide to the bring-up of the next gen (workarounds have a habit of
> + * persisting). Anything older than that should be removed along with the
> + * complications they introduce.
> */
Ack for putting that in a patch and merging.
BR,
Jani.
> static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> {
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-17 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 13:51 [PATCH] drm/i915: Remove pre-production pooled-EU w/a for Broxton Chris Wilson
2017-11-14 14:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-14 20:19 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-15 18:01 ` [PATCH] " David Weinehall
2017-11-15 18:06 ` Chris Wilson
2017-11-16 9:22 ` Jani Nikula
2017-11-16 20:55 ` Rodrigo Vivi
2017-11-17 7:44 ` Jani Nikula
2017-11-17 9:59 ` Chris Wilson
2017-11-17 10:04 ` Jani Nikula [this message]
2017-11-16 11:11 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ine95ii7.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox