RE: [PATCH v4 0/2] Refactor MST DSC Determination Policy

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 21 Nov 2024, "Zuo, Jerry" <Jerry.Zuo@amd.com> wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Lyude, Jani, Imre, Simona:
>
>      Please kindly review the patch series at your convenient
>      time. Thanks.

There's still way too much going on in one patch. It's too hard to do
proper detailed review on this. I don't have that kind of time to spend.

If you were to get a regression report on this maybe a year down the
line when it hits major distros, what are your chances of pinpointing
what went wrong? What are your chances of quickly debugging and fixing
it? I'm thinking slim.

MST is too complicated to trap ourselves in that scenario.

Please find a way to do incremental refactoring first to support your
functional changes.

BR,
Jani.


>
> Regards,
> Jerry
>
>> -----Original Message-----
>> From: Fangzhi Zuo <Jerry.Zuo@amd.com>
>> Sent: Friday, November 8, 2024 12:42 PM
>> To: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; intel-
>> gfx@lists.freedesktop.org; lyude@redhat.com; jani.nikula@intel.com;
>> imre.deak@intel.com; simona@ffwll.ch; Lin, Wayne <Wayne.Lin@amd.com>
>> Cc: Wentland, Harry <Harry.Wentland@amd.com>; Siqueira, Rodrigo
>> <Rodrigo.Siqueira@amd.com>; Zuo, Jerry <Jerry.Zuo@amd.com>
>> Subject: [PATCH v4 0/2] Refactor MST DSC Determination Policy
>>
>> The patch series is to refactor existing dsc determination policy for dsc
>> decompression and dsc passthrough given a mst output port.
>>
>> Original routine was written based on different peer device types which is not
>> accurate and shows difficulty when expanding support of products that do not fully
>> comply with DP specs.
>>
>> To make the routine more accurate and generic, the series includes below changes:
>> 1. Refactor MST DSC determination policy solely based on
>>    topology connection status and dsc dpcd capability info.
>> 2. Dependency changes required for each vendor due to interface change.
>>
>> v2: split original single patch into two
>> v3: rebase against the latest code
>> v4: fix a ci issue
>>
>> Fangzhi Zuo (2):
>>   drm/display/dsc: Refactor DRM MST DSC Determination Policy
>>   drm/display/dsc: MST DSC Interface Change
>>
>>  .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |   2 +-
>>  .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |  20 +-
>>  .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |  28 +-
>>  drivers/gpu/drm/display/drm_dp_mst_topology.c | 261 ++++++++----------
>>  drivers/gpu/drm/i915/display/intel_dp.c       |   2 +-
>>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
>>  include/drm/display/drm_dp_mst_helper.h       |   9 +-
>>  7 files changed, 147 insertions(+), 178 deletions(-)
>>
>> --
>> 2.43.0
>

-- 
Jani Nikula, Intel