From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>,
Dorcas AnonoLitunya <anonolitunya@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, karolinadrobnik@gmail.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove prohibited space after opening parenthesis
Date: Thu, 02 Nov 2023 14:26:26 +0200 [thread overview]
Message-ID: <87jzr02vf1.fsf@intel.com> (raw)
In-Reply-To: <ZT_5InkXDfIzzonu@ashyti-mobl2.lan>
On Mon, 30 Oct 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Dorcas,
>
> On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote:
>> Removes space after opening parenthesis.
>>
>> Fixes the checkpatch.pl error:
>> ERROR: space prohibited after that opening parenthesis '('
>>
>> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> index 4a11219e560e..40687806d22a 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> @@ -47,7 +47,7 @@
>> #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE)
>> #define GEN11_LR_CONTEXT_RENDER_SIZE (14 * PAGE_SIZE)
>>
>> -#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE)
>> +#define GEN8_LR_CONTEXT_OTHER_SIZE (2 * PAGE_SIZE)
>
> I'm actually having second thoughts on this change. The space was
> left on purpose in order to be aligned with the defines above.
I'd merge the patch.
BR,
Jani.
>
> On the other hand, this is a bit detached from the others and
> this change makes checkpatch happy.
>
> This is one of those patches that are not right and not wrong
> either.
>
> I'll give it a bit more time and merge if no complains arise.
>
> Andi
>
>> #define MAX_MMIO_BASES 3
>> struct engine_info {
>> --
>> 2.42.0.345.gaab89be2eb
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-11-02 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 17:47 [Intel-gfx] [PATCH] drm/i915/gt: Remove prohibited space after opening parenthesis Dorcas AnonoLitunya
2023-10-28 0:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-10-29 9:36 ` [Intel-gfx] [PATCH] " Andi Shyti
2023-10-30 18:42 ` Andi Shyti
2023-10-30 20:13 ` Dorcas Anono Litunya
2023-11-02 12:26 ` Jani Nikula [this message]
2023-11-03 0:37 ` Andi Shyti
2023-10-30 21:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzr02vf1.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=anonolitunya@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=karolinadrobnik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox