From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: no need for gt/gen8_ppgtt.h
Date: Fri, 09 Dec 2022 10:57:02 +0200 [thread overview]
Message-ID: <87k031ymxt.fsf@intel.com> (raw)
In-Reply-To: <20221208191056.imesdzudpeltiuno@ldmartin-desk2.lan>
On Thu, 08 Dec 2022, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Thu, Dec 08, 2022 at 03:36:38PM +0200, Jani Nikula wrote:
>>Remove an unnecessary include.
>>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> maybe we should run a script/something to check for unneeded includes
> and commit everything? Then we can add a check in CI
>
> include-what-you-use does this, but I'm not sure it can grok
> kernel / i915
Yeah I've looked at it. Would be nice to use it via CHECK=iwyu, but it
needs a wrapper to deal with the parameters, and haven't gotten around
to that yet. And from past experience with iwyu, I'm not really
expecting a whole lot. It can be a bit overzealous.
BR,
Jani.
>
> Anyway,
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Lucas De Marchi
>
>>---
>> drivers/gpu/drm/i915/display/intel_display.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>>index 32b257157186..6cdfdae2c712 100644
>>--- a/drivers/gpu/drm/i915/display/intel_display.c
>>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>>@@ -70,8 +70,6 @@
>> #include "gem/i915_gem_lmem.h"
>> #include "gem/i915_gem_object.h"
>>
>>-#include "gt/gen8_ppgtt.h"
>>-
>> #include "g4x_dp.h"
>> #include "g4x_hdmi.h"
>> #include "hsw_ips.h"
>>--
>>2.34.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-12-09 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 13:36 [Intel-gfx] [PATCH] drm/i915/display: no need for gt/gen8_ppgtt.h Jani Nikula
2022-12-08 16:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-08 19:10 ` [Intel-gfx] [PATCH] " Lucas De Marchi
2022-12-09 8:57 ` Jani Nikula [this message]
2022-12-09 8:57 ` Jani Nikula
2022-12-09 3:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k031ymxt.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox