From: Jani Nikula <jani.nikula@intel.com>
To: "Bharadiya\,Pankaj" <pankaj.laxminarayan.bharadiya@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Wambui Karuga <wambui.karugax@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 02/17] drm/i915/panel: use struct drm_device based logging
Date: Mon, 06 Apr 2020 15:44:40 +0300 [thread overview]
Message-ID: <87k12slr5z.fsf@intel.com> (raw)
In-Reply-To: <20200406111638.GA16489@plaxmina-desktop.iind.intel.com>
On Mon, 06 Apr 2020, "Bharadiya,Pankaj" <pankaj.laxminarayan.bharadiya@intel.com> wrote:
> Adding new i915 variable seems to be redundant here since we can
> directly use "connector->base.dev" for getting struct drm_device
> pointer.
We could. However, struct drm_i915_private *i915 is widely used and
needed throughout the driver, all over the place. I'd rather add i915
now instead of first using connector->base.dev or whatever, and having
someone add i915 at a later time and then converting to &i915->drm.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-06 12:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:48 [Intel-gfx] [PATCH 01/17] drm/i915/audio: use struct drm_device based logging Jani Nikula
2020-04-02 11:48 ` [Intel-gfx] [PATCH 02/17] drm/i915/panel: " Jani Nikula
2020-04-06 10:54 ` Bharadiya,Pankaj
2020-04-06 11:07 ` Jani Nikula
2020-04-06 11:16 ` Bharadiya,Pankaj
2020-04-06 12:44 ` Jani Nikula [this message]
2020-04-07 11:16 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 03/17] drm/i915/tc: " Jani Nikula
2020-04-07 11:26 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 04/17] drm/i915/dp: " Jani Nikula
2020-04-06 11:04 ` Bharadiya,Pankaj
2020-04-06 12:50 ` Jani Nikula
2020-04-07 11:35 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 05/17] drm/i915/crt: " Jani Nikula
2020-04-07 11:40 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 06/17] drm/i915/debugfs: " Jani Nikula
2020-04-07 11:49 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 07/17] drm/i915/bw: " Jani Nikula
2020-04-07 15:54 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 08/17] drm/i915/state: " Jani Nikula
2020-04-08 7:59 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 09/17] drm/i915/switcheroo: " Jani Nikula
2020-04-08 8:12 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 10/17] drm/i915/uc: prefer " Jani Nikula
2020-04-08 8:31 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 11/17] drm/i915/error: " Jani Nikula
2020-04-08 8:31 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 12/17] drm/i915/pmu: " Jani Nikula
2020-04-08 8:42 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 13/17] drm/i915/dram: " Jani Nikula
2020-04-08 8:43 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 14/17] drm/i915/uncore: " Jani Nikula
2020-04-08 8:44 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 15/17] drm/i915/stolen: " Jani Nikula
2020-04-08 8:45 ` Wambui Karuga
2020-04-02 11:48 ` [Intel-gfx] [PATCH 16/17] drm/i915/gt: " Jani Nikula
2020-04-08 8:49 ` Wambui Karuga
2020-04-15 7:01 ` Chris Wilson
2020-04-15 11:08 ` Jani Nikula
2020-04-02 11:48 ` [Intel-gfx] [PATCH 17/17] drm/i915/uc: " Jani Nikula
2020-04-08 8:51 ` Wambui Karuga
2020-04-02 12:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/17] drm/i915/audio: use " Patchwork
2020-04-03 12:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-04-07 11:12 ` [Intel-gfx] [PATCH 01/17] " Wambui Karuga
2020-04-08 10:54 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k12slr5z.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox