From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: use DRM_ERROR() instead of drm_err()
Date: Thu, 03 Oct 2019 11:32:46 +0300 [thread overview]
Message-ID: <87k19m9qkx.fsf@intel.com> (raw)
In-Reply-To: <20191002150025.GW1208@intel.com>
On Wed, 02 Oct 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Oct 02, 2019 at 05:54:04PM +0300, Jani Nikula wrote:
>> Unify on current common usage to allow repurposing drm_err() later. Fix
>> newlines while at it.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_display.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index d99c59e97568..781f6ea7ccf9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -12562,10 +12562,10 @@ pipe_config_infoframe_mismatch(struct drm_i915_private *dev_priv,
>> drm_dbg(DRM_UT_KMS, "found");
>> hdmi_infoframe_log(KERN_DEBUG, dev_priv->drm.dev, b);
>> } else {
>> - drm_err("mismatch in %s infoframe", name);
>> - drm_err("expected:");
>> + DRM_ERROR("mismatch in %s infoframe\n", name);
>> + DRM_ERROR("expected:\n");
>> hdmi_infoframe_log(KERN_ERR, dev_priv->drm.dev, a);
>> - drm_err("found");
>> + DRM_ERROR("found:\n");
>> hdmi_infoframe_log(KERN_ERR, dev_priv->drm.dev, b);
>> }
>> }
>> @@ -12583,7 +12583,7 @@ pipe_config_mismatch(bool fastset, const char *name, const char *format, ...)
>> if (fastset)
>> drm_dbg(DRM_UT_KMS, "fastset mismatch in %s %pV", name, &vaf);
>> else
>> - drm_err("mismatch in %s %pV", name, &vaf);
>> + DRM_ERROR("mismatch in %s %pV\n", name, &vaf);
>>
>> va_end(args);
>> }
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-03 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:54 [PATCH 1/2] drm/i915: use DRM_ERROR() instead of drm_err() Jani Nikula
2019-10-02 14:54 ` [PATCH 2/2] drm/i915: use DRM_DEBUG_KMS() instead of drm_dbg(DRM_UT_KMS, ...) Jani Nikula
2019-10-02 15:00 ` [PATCH 1/2] drm/i915: use DRM_ERROR() instead of drm_err() Ville Syrjälä
2019-10-03 8:32 ` Jani Nikula [this message]
2019-10-02 21:54 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-10-03 5:37 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k19m9qkx.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox