public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 5/6] drm/i915: Add i915_param charp macro	magic
Date: Tue, 21 Feb 2017 18:10:06 +0200	[thread overview]
Message-ID: <87k28jjzj5.fsf@intel.com> (raw)
In-Reply-To: <20170207091256.GA20195@nuc-i3427.alporthouse.com>

On Tue, 07 Feb 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Mon, Feb 06, 2017 at 02:32:17PM +0200, Joonas Lahtinen wrote:
>> On ma, 2017-02-06 at 09:51 +0000, Chris Wilson wrote:
>> > Handling the dynamic charp module parameter requires us to copy it for
>> > the error state, or remember to lock it when reading (in case it used
>> > with 0600).
>> > 
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> 
>> I'm bit hesitant that we merge known dead code here.
>> 
>> Maybe the guc firmware path override would be useful to excercise this?
>
> Merged upto this point until we have a use for new parameter types.

I could use this now, care to send a rebased/refreshed version, please?

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-21 16:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06  9:51 [PATCH v3 1/6] drm/i915: Generate i915_params {} using a macro Chris Wilson
2017-02-06  9:51 ` [PATCH v3 2/6] drm/i915: Use bool i915_param.alpha_support Chris Wilson
2017-02-06  9:51 ` [PATCH v3 3/6] drm/i915: Capture module parameters for the GPU error state Chris Wilson
2017-02-06 11:13   ` Joonas Lahtinen
2017-02-06 11:24   ` Chris Wilson
2017-02-06 11:29     ` Chris Wilson
2017-02-06  9:51 ` [PATCH v3 4/6] drm/i915: Show the current i915_params in debugfs/i915_capabilites Chris Wilson
2017-02-06 11:21   ` Joonas Lahtinen
2017-02-06  9:51 ` [PATCH v3 5/6] drm/i915: Add i915_param charp macro magic Chris Wilson
2017-02-06 12:32   ` Joonas Lahtinen
2017-02-06 13:06     ` Chris Wilson
2017-02-07  9:12     ` Chris Wilson
2017-02-21 16:10       ` Jani Nikula [this message]
2017-02-21 16:26         ` [PATCH] " Chris Wilson
2017-02-22 10:06           ` Jani Nikula
2017-02-22 10:11             ` Chris Wilson
2017-02-22 10:29               ` Joonas Lahtinen
2017-02-22 10:33                 ` Chris Wilson
2017-02-22 10:30               ` Jani Nikula
2017-02-22 10:37                 ` Chris Wilson
2017-02-06  9:51 ` [PATCH v3 6/6] drm/i915: The return of i915_gpu_info to debugfs Chris Wilson
2017-02-07  9:09   ` Chris Wilson
2017-02-06 13:25 ` ✗ Fi.CI.BAT: failure for series starting with [v3,1/6] drm/i915: Generate i915_params {} using a macro Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k28jjzj5.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox