From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/dp: set sink to power down mode on dp disable
Date: Wed, 13 Nov 2013 10:03:53 +0200 [thread overview]
Message-ID: <87k3gcsp7a.fsf@intel.com> (raw)
In-Reply-To: <20131112172718.GA9395@phenom.ffwll.local>
On Tue, 12 Nov 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Nov 12, 2013 at 09:37:52AM -0700, Todd Previte wrote:
>> On 11/12/13 8:10 AM, Jani Nikula wrote:
>> >We used to put the local sink and any downstream sinks to power down
>> >mode at disable or dpms off using the DPCD SET_POWER register, until
>> >this was broken by
>> >
>> >commit e8cb455876fa8f67c6aba394d0a14b697bf04cc3
>> >Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>> >Date: Sun Jul 1 13:05:48 2012 +0200
>> >
>> > drm/i915/dp: convert to encoder disable/enable
>> >
>> >Fix it.
>> >
>> >Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >---
>> > drivers/gpu/drm/i915/intel_dp.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> >index dbe4840..cbf33be 100644
>> >--- a/drivers/gpu/drm/i915/intel_dp.c
>> >+++ b/drivers/gpu/drm/i915/intel_dp.c
>> >@@ -1774,7 +1774,7 @@ static void intel_disable_dp(struct intel_encoder *encoder)
>> > * ensure that we have vdd while we switch off the panel. */
>> > ironlake_edp_panel_vdd_on(intel_dp);
>> > ironlake_edp_backlight_off(intel_dp);
>> >- intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
>> >+ intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
>> > ironlake_edp_panel_off(intel_dp);
>> >
>> > /* cpu edp my only be disable _after_ the cpu pipe/plane is disabled. */
>>
>> Reviewed-by: Todd Previte <tprevite@gmail.com>
>
> Picked up for -fixes, thanks for the patch. Atm without a cc: stable, but
> I'll add that if we get a tested-by from a bug report. Might be worth a
> shot to haggle this by some dp bugzillas ...
I'm really not sure what the impact might be other than a potential
power regression fix, and I presume a smart sink would save power when
we put the main link down. The DP spec is a bit light on this. For eDP
we cut the power anyway, so perhaps the impact is on external displays
only, and people might not even pay so much attention to their power
consumption.
I guess I could have put that in the commit message too, but oh well.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2013-11-13 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 15:10 [PATCH] drm/i915/dp: set sink to power down mode on dp disable Jani Nikula
2013-11-12 16:37 ` Todd Previte
2013-11-12 17:27 ` Daniel Vetter
2013-11-13 8:03 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3gcsp7a.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tprevite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox