Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915/dp: Limit SST link rate to <=8.1Gbps
Date: Thu, 08 Feb 2024 17:55:53 +0200	[thread overview]
Message-ID: <87le7var1y.fsf@intel.com> (raw)
In-Reply-To: <20240208154552.14545-1-ville.syrjala@linux.intel.com>

On Thu, 08 Feb 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Limit the link rate to HBR3 or below (<=8.1Gbps) in SST mode.
> UHBR (10Gbps+) link rates require 128b/132b channel encoding
> which we have not yet hooked up into the SST/no-sideband codepaths.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

My bad.

I guess this is the smallest most isolated fix for stable.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>



> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index ab415f41924d..5045c34a16be 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2356,6 +2356,9 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
>  	limits->min_rate = intel_dp_common_rate(intel_dp, 0);
>  	limits->max_rate = intel_dp_max_link_rate(intel_dp);
>  
> +	/* FIXME 128b/132b SST support missing */
> +	limits->max_rate = min(limits->max_rate, 810000);
> +
>  	limits->min_lane_count = 1;
>  	limits->max_lane_count = intel_dp_max_lane_count(intel_dp);

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-02-08 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 15:45 [PATCH] drm/i915/dp: Limit SST link rate to <=8.1Gbps Ville Syrjala
2024-02-08 15:55 ` Jani Nikula [this message]
2024-02-08 23:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-02-09  5:25 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le7var1y.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox