From: Jani Nikula <jani.nikula@intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: remove display raw reg read/write micro-optimizations
Date: Tue, 27 Jun 2023 10:53:01 +0300 [thread overview]
Message-ID: <87leg5tk82.fsf@intel.com> (raw)
In-Reply-To: <ZJRV0ngY8zv/Vo5H@ashyti-mobl2.lan>
On Thu, 22 Jun 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Jani,
>
> On Wed, Jun 21, 2023 at 09:38:05PM +0300, Jani Nikula wrote:
>> Convert the raw_reg_read() and raw_reg_write() calls in display GU MISC
>> and INT CTL handling to regular intel_uncore_read() and
>> intel_uncore_write(). These were neglible micro-optimizations, and
>
> /neglible/negligible/
>
>> removing them helps the display code reuse in the Xe driver.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks, but back to the drawing board:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119703v1/bat-dg2-9/igt@i915_pm_rpm@module-reload.html#dmesg-warnings1253
>
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-06-27 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 18:38 [Intel-gfx] [PATCH] drm/i915/display: remove display raw reg read/write micro-optimizations Jani Nikula
2023-06-21 23:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-06-22 14:08 ` [Intel-gfx] [PATCH] " Andi Shyti
2023-06-27 7:53 ` Jani Nikula [this message]
2023-06-28 17:17 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leg5tk82.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox