From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a
Date: Wed, 14 Apr 2021 12:18:48 +0300 [thread overview]
Message-ID: <87lf9lfclj.fsf@intel.com> (raw)
In-Reply-To: <20210412054607.18133-3-ville.syrjala@linux.intel.com>
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We lost a CCS related w/a on glk when the display version
> became 10 instead of 9. Restore the correct check.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 411b46c012f8..7eac893b4f96 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1406,7 +1406,8 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)
> * require the entire fb to accommodate that to avoid
> * potential runtime errors at plane configuration time.
> */
> - if (IS_DISPLAY_VER(dev_priv, 9) && color_plane == 0 && fb->width > 3840)
> + if ((IS_DISPLAY_VER(dev_priv, 9) || IS_GEMINILAKE(dev_priv)) &&
> + color_plane == 0 && fb->width > 3840)
> tile_width *= 4;
> /*
> * The main surface pitch must be padded to a multiple of four
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-14 9:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
2021-04-12 5:46 ` [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a Ville Syrjala
2021-04-14 9:14 ` Jani Nikula
2021-04-14 9:17 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a Ville Syrjala
2021-04-14 9:18 ` Jani Nikula [this message]
2021-04-12 5:46 ` [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again Ville Syrjala
2021-04-14 9:19 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk Ville Syrjala
2021-04-14 9:25 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks Ville Syrjala
2021-04-14 9:26 ` Jani Nikula
2021-04-12 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix glk display version regressions Patchwork
2021-04-12 6:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-12 7:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-13 10:57 ` [Intel-gfx] [PATCH 0/5] " Jani Nikula
2021-04-14 9:34 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf9lfclj.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox