From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tdz@users.sourceforge.net>
Subject: Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check
Date: Tue, 26 Mar 2019 11:30:57 +0200 [thread overview]
Message-ID: <87lg12yoby.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190326050843.GA20038@kadam>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The live_context() function returns error pointers. It never returns
> NULL.
>
> Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a full GGTT")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
i915_request.c has another :)
-Mika
> ---
> drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
> index 9a9451846b33..89766688e420 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
> @@ -455,7 +455,7 @@ static int igt_evict_contexts(void *arg)
> struct i915_gem_context *ctx;
>
> ctx = live_context(i915, file);
> - if (!ctx)
> + if (IS_ERR(ctx))
> break;
>
> /* We will need some GGTT space for the rq's context */
> --
> 2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-26 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 5:08 [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check Dan Carpenter
2019-03-26 9:30 ` Mika Kuoppala [this message]
2019-03-26 14:53 ` Chris Wilson
2019-03-26 15:35 ` Dan Carpenter
2019-03-26 14:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-26 20:06 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-03-27 9:20 [PATCH] " Mika Kuoppala
2019-03-27 9:25 ` Chris Wilson
2019-03-27 9:32 ` Mika Kuoppala
2019-03-27 9:52 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg12yoby.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tdz@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox