From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915/vgpu: Disallow loading on old vGPU hosts
Date: Mon, 03 Dec 2018 18:22:52 +0200 [thread overview]
Message-ID: <87lg56eg0z.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <154385337597.29788.18024034455079390870@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2018-12-03 13:40:26)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Since commit fd8526e50902 ("drm/i915/execlists: Trust the CSB") we
>> > actually broke the force-mmio mode for our execlists implementation. No
>> > one noticed, so ergo no one is actually using an old vGPU host (where we
>> > required the older method) and so can simply remove the broken support.
>> >
>> > v2: csb_read can go as well (Mika)
>> >
>> > Reported-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> > Fixes: fd8526e50902 ("drm/i915/execlists: Trust the CSB")
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>
>> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> Pushed, thanks. That should make your extended CSB patches for icl that
> much more straightforward, right?
Very much so. Now just have to figure out how to make the
cpu/gpu dance together. The extended CSB is not enough
by itself :(
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-03 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 10:42 [PATCH] drm/i915/vgpu: Disallow loading on old vGPU hosts Chris Wilson
2018-11-30 12:01 ` Mika Kuoppala
2018-11-30 12:08 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-30 12:59 ` [PATCH v2] " Chris Wilson
2018-12-03 13:40 ` Mika Kuoppala
2018-12-03 16:09 ` Chris Wilson
2018-12-03 16:22 ` Mika Kuoppala [this message]
2018-11-30 13:25 ` ✓ Fi.CI.BAT: success for drm/i915/vgpu: Disallow loading on old vGPU hosts (rev2) Patchwork
2018-12-01 6:31 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg56eg0z.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox