From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Daniel <thomas.daniel@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bdw: Enable execlists by default where supported
Date: Thu, 11 Dec 2014 14:02:48 +0200 [thread overview]
Message-ID: <87lhme8kd3.fsf@intel.com> (raw)
In-Reply-To: <1418296174-12765-1-git-send-email-thomas.daniel@intel.com>
On Thu, 11 Dec 2014, Thomas Daniel <thomas.daniel@intel.com> wrote:
> Execlist support in the i915 driver is now considered good enough for the
> feature to be enabled by default on Gen8 and later and routinely tested.
> Adjusted i915 parameters structure initialization to reflect this and updated
> the comment in intel_sanitize_enable_execlists().
Please update the MODULE_PARM_DESC too.
BR,
Jani.
>
> Issue: VIZ-2020
> Signed-off-by: Thomas Daniel <thomas.daniel@intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.c | 2 +-
> drivers/gpu/drm/i915/intel_lrc.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index c91cb20..ad685d8 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = {
> .vbt_sdvo_panel_type = -1,
> .enable_rc6 = -1,
> .enable_fbc = -1,
> - .enable_execlists = 0,
> + .enable_execlists = -1,
> .enable_hangcheck = true,
> .enable_ppgtt = -1,
> .enable_psr = 0,
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 89b5577..4dc6d42 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring,
> * @enable_execlists: value of i915.enable_execlists module parameter.
> *
> * Only certain platforms support Execlists (the prerequisites being
> - * support for Logical Ring Contexts and Aliasing PPGTT or better),
> - * and only when enabled via module parameter.
> + * support for Logical Ring Contexts and Aliasing PPGTT or better).
> *
> * Return: 1 if Execlists is supported and has to be enabled.
> */
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-11 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 11:09 [PATCH] drm/i915/bdw: Enable execlists by default where supported Thomas Daniel
2014-12-11 12:02 ` Jani Nikula [this message]
2014-12-15 10:04 ` Daniel Vetter
2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel
2014-12-11 21:51 ` shuang.he
2014-12-15 10:06 ` Daniel Vetter
2014-12-15 10:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhme8kd3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.daniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox