Re: [PATCH 1/4] drm/i915: Fix CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n build

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 11 Feb 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Looks like I missed one of myriad CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
> special cases when converting the intel_display_power_{get,put}()
> code to use struct intel_display. Only noticed after the fact
> when building a EXPERT=n kernel :/
>
> Fixes: 5dcfda5cfa42 ("drm/i915: Convert intel_display_power_{get,put}*() to intel_display")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

I guess I was reviewing everything that was changed, and trusted the
unchanged stuff to the compiler.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_power.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index b5d67b6c73cf..1e4e113999fb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -217,7 +217,7 @@ intel_display_power_put_async_delay(struct intel_display *display,
>  	__intel_display_power_put_async(display, domain, wakeref, delay_ms);
>  }
>  #else
> -void intel_display_power_put_unchecked(struct drm_i915_private *dev_priv,
> +void intel_display_power_put_unchecked(struct intel_display *display,
>  				       enum intel_display_power_domain domain);
>  
>  static inline void

-- 
Jani Nikula, Intel