Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
	"Govindapillai, Vinod" <vinod.govindapillai@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: remove display device info from i915 capabilities
Date: Thu, 26 Oct 2023 16:26:38 +0300	[thread overview]
Message-ID: <87msw57bw1.fsf@intel.com> (raw)
In-Reply-To: <SJ1PR11MB6129C4F69257CC05ABAF4659B9D4A@SJ1PR11MB6129.namprd11.prod.outlook.com>

On Thu, 19 Oct 2023, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
>> -----Original Message-----
>> From: Govindapillai, Vinod <vinod.govindapillai@intel.com>
>> Sent: Wednesday, October 18, 2023 3:57 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Sharma, Swati2
>> <swati2.sharma@intel.com>; Borah, Chaitanya Kumar
>> <chaitanya.kumar.borah@intel.com>
>> Subject: [PATCH v4 2/2] drm/i915: remove display device info from i915
>> capabilities
>> 
>> Display device and display runtime info is exposed as part of
>> i915_display_capabilities debugfs entry. Remove this information from i915_
>> capabilities as it is now reduntant.
>> 
>> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>
> LGTM.
>
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

Thanks for the patch and review, pushed to drm-intel-next.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/i915_debugfs.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
>> b/drivers/gpu/drm/i915/i915_debugfs.c
>> index e9b79c2c37d8..bb48feb3b12e 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -67,7 +67,6 @@ static int i915_capabilities(struct seq_file *m, void *data)
>>  	seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
>> 
>>  	intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
>> -	intel_display_device_info_print(DISPLAY_INFO(i915),
>> DISPLAY_RUNTIME_INFO(i915), &p);
>>  	i915_print_iommu_status(i915, &p);
>>  	intel_gt_info_print(&to_gt(i915)->info, &p);
>>  	intel_driver_caps_print(&i915->caps, &p);
>> --
>> 2.34.1
>

-- 
Jani Nikula, Intel

  reply	other threads:[~2023-10-26 13:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 10:27 [Intel-gfx] [PATCH v4 0/2] display device info as a separate debugfs entry Vinod Govindapillai
2023-10-18 10:27 ` [Intel-gfx] [PATCH v4 1/2] drm/i915/display: debugfs entry to list display capabilities Vinod Govindapillai
2023-10-19  9:30   ` Borah, Chaitanya Kumar
2023-10-25 12:08     ` Jani Nikula
2023-10-18 10:27 ` [Intel-gfx] [PATCH v4 2/2] drm/i915: remove display device info from i915 capabilities Vinod Govindapillai
2023-10-19  9:32   ` Borah, Chaitanya Kumar
2023-10-26 13:26     ` Jani Nikula [this message]
2023-10-18 22:02 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for display device info as a separate debugfs entry (rev6) Patchwork
2023-10-18 22:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-18 22:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-19  1:05 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msw57bw1.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox