From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Egbert Eich <eich@suse.de>, Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Add messages usful for HPD strom detection debugging
Date: Fri, 26 Jul 2013 14:25:16 +0300 [thread overview]
Message-ID: <87mwp95zs3.fsf@intel.com> (raw)
In-Reply-To: <1374834630-6171-1-git-send-email-eich@suse.de>
On Fri, 26 Jul 2013, Egbert Eich <eich@suse.de> wrote:
> For HPD storm detection we now mask out individual interrupt source
> bits. We have already seen a case where HPD interrupt enable bits
> were assigned to the wrong pins. To track these conditions more
> easily add some debugging messages.
The code seems okay, please spellcheck the subject and debug prints! :)
BR,
Jani.
>
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index ee3e49c..1f3a971 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -919,6 +919,10 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev,
> spin_lock(&dev_priv->irq_lock);
> for (i = 1; i < HPD_NUM_PINS; i++) {
>
> + WARN(((hpd[i] & hotplug_trigger) &&
> + dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED),
> + "Received HPD intterupt although disabled\n");
> +
> if (!(hpd[i] & hotplug_trigger) ||
> dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED)
> continue;
> @@ -929,6 +933,7 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev,
> + msecs_to_jiffies(HPD_STORM_DETECT_PERIOD))) {
> dev_priv->hpd_stats[i].hpd_last_jiffies = jiffies;
> dev_priv->hpd_stats[i].hpd_cnt = 0;
> + DRM_DEBUG_KMS("Received HPD interrupt on PIN %d - cnt: 0\n", i);
> } else if (dev_priv->hpd_stats[i].hpd_cnt > HPD_STORM_THRESHOLD) {
> dev_priv->hpd_stats[i].hpd_mark = HPD_MARK_DISABLED;
> dev_priv->hpd_event_bits &= ~(1 << i);
> @@ -936,6 +941,8 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev,
> storm_detected = true;
> } else {
> dev_priv->hpd_stats[i].hpd_cnt++;
> + DRM_DEBUG_KMS("Received HPD interrupt on PIN %d - cnt: %d\n", i,
> + dev_priv->hpd_stats[i].hpd_cnt);
> }
> }
>
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-07-26 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 10:30 [PATCH] drm/i915: Add messages usful for HPD strom detection debugging Egbert Eich
2013-07-26 11:25 ` Jani Nikula [this message]
2013-07-26 12:14 ` [PATCH V2] drm/i915: Add messages useful for HPD storm detection debugging (v2) Egbert Eich
2013-07-26 12:23 ` Jani Nikula
2013-07-26 17:44 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwp95zs3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=eich@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox