From: Javier Martinez Canillas <javierm@redhat.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m
Date: Fri, 15 Dec 2023 12:34:48 +0100 [thread overview]
Message-ID: <87o7ern1gn.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20231215111129.9559-1-ville.syrjala@linux.intel.com>
Ville Syrjala <ville.syrjala@linux.intel.com> writes:
Hello Ville,
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The original rationale for
> commit cd456f8d06d2 ("drm: Restrict stackdepot usage to builtin drm.ko")
> was that depot_save_stack() (which is what we used back then)
> wasn't exported. stack_depot_save() (which is what we use now) is
> exported however, so relax the dependency allow CONFIG_DRM_MM_DEBUG
> with DRM=m.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 31cfe2c2a2af..4b8b8f8a0e72 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -42,7 +42,7 @@ config DRM_MIPI_DSI
> config DRM_DEBUG_MM
> bool "Insert extra checks and debug info into the DRM range managers"
> default n
> - depends on DRM=y
> + depends on DRM
> depends on STACKTRACE_SUPPORT
> select STACKDEPOT
> help
> --
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-12-15 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 11:11 [PATCH] drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m Ville Syrjala
2023-12-15 11:34 ` Javier Martinez Canillas [this message]
2023-12-18 12:56 ` Ville Syrjälä
2023-12-15 19:40 ` ✗ Fi.CI.BAT: failure for " Patchwork
2023-12-16 3:00 ` ✓ Fi.CI.BAT: success for drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m (rev2) Patchwork
2023-12-16 3:50 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ern1gn.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox