From: Jani Nikula <jani.nikula@intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix intel_display_irq.c include order
Date: Wed, 17 May 2023 11:24:05 +0300 [thread overview]
Message-ID: <87o7mjgyca.fsf@intel.com> (raw)
In-Reply-To: <168424225552.36532.14479350464099293863@gjsousa-mobl2>
On Tue, 16 May 2023, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Jani Nikula (2023-05-16 09:29:26)
>>I meant to sort the includes before submitting commit 2b874a027810
>>("drm/i915/irq: split out display irq handling") but forgot, and it
>>wasn't noticed in review either. Sort the includes.
>
> Oops... My bad.
Nah, mine, really.
>
>>
>>Cc: Gustavo Sousa <gustavo.sousa@intel.com>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>>---
>> drivers/gpu/drm/i915/display/intel_display_irq.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
>>index 0eedd1ebb389..3b2a287d2041 100644
>>--- a/drivers/gpu/drm/i915/display/intel_display_irq.c
>>+++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
>>@@ -3,23 +3,23 @@
>> * Copyright © 2023 Intel Corporation
>> */
>>
>>+#include "gt/intel_rps.h"
>> #include "i915_drv.h"
>> #include "i915_irq.h"
>> #include "i915_reg.h"
>> #include "icl_dsi_regs.h"
>>-#include "intel_display_irq.h"
>>-#include "intel_display_types.h"
>>-#include "intel_hotplug_irq.h"
>>-#include "intel_psr_regs.h"
>> #include "intel_crtc.h"
>>+#include "intel_de.h"
>>+#include "intel_display_irq.h"
>> #include "intel_display_trace.h"
>>+#include "intel_display_types.h"
>> #include "intel_dp_aux.h"
>>-#include "intel_gmbus.h"
>>+#include "intel_fdi_regs.h"
>> #include "intel_fifo_underrun.h"
>>+#include "intel_gmbus.h"
>>+#include "intel_hotplug_irq.h"
>> #include "intel_psr.h"
>>-#include "intel_fdi_regs.h"
>>-#include "gt/intel_rps.h"
>>-#include "intel_de.h"
>>+#include "intel_psr_regs.h"
>>
>> static void
>> intel_handle_vblank(struct drm_i915_private *dev_priv, enum pipe pipe)
>>--
>>2.39.2
>>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-05-17 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 12:29 [Intel-gfx] [PATCH] drm/i915: fix intel_display_irq.c include order Jani Nikula
2023-05-16 13:04 ` Gustavo Sousa
2023-05-17 8:24 ` Jani Nikula [this message]
2023-05-16 14:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-16 20:57 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7mjgyca.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox