From: Jani Nikula <jani.nikula@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size
Date: Thu, 21 Jun 2018 11:57:59 +0300 [thread overview]
Message-ID: <87o9g4v7mw.fsf@intel.com> (raw)
In-Reply-To: <20180621000827.28301-1-jose.souza@intel.com>
On Wed, 20 Jun 2018, José Roberto de Souza <jose.souza@intel.com> wrote:
Please add a commit message, always.
Please make the subject prefix just "drm/i915/fbc" because cnl is
misleading there.
BR,
Jani.
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_fbc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> index b431b6733cc1..eb0f95390968 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -714,7 +714,10 @@ static bool intel_fbc_hw_tracking_covers_screen(struct intel_crtc *crtc)
> struct intel_fbc *fbc = &dev_priv->fbc;
> unsigned int effective_w, effective_h, max_w, max_h;
>
> - if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) {
> + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) {
> + max_w = 5120;
> + max_h = 4096;
> + } else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) {
> max_w = 4096;
> max_h = 4096;
> } else if (IS_G4X(dev_priv) || INTEL_GEN(dev_priv) >= 5) {
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-21 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 0:08 [PATCH 1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size José Roberto de Souza
2018-06-21 0:08 ` [PATCH 2/2] drm/i915/fbc: Resize CFB in non-full modeset paths José Roberto de Souza
2018-06-21 0:14 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size Patchwork
2018-06-21 0:31 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-21 8:08 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-21 8:57 ` Jani Nikula [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-06 20:53 [PATCH 1/2] " José Roberto de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9g4v7mw.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox