Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Daniel Vetter" <daniel@ffwll.ch>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Wait up all outstanding tx waiters
Date: Mon, 15 May 2017 18:02:31 +0300	[thread overview]
Message-ID: <87o9uuduyg.fsf@intel.com> (raw)
In-Reply-To: <20170515133759.ivhccpn23xycukh7@phenom.ffwll.local>

On Mon, 15 May 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, May 15, 2017 at 03:33:12PM +0300, Ville Syrjälä wrote:
>> On Mon, May 15, 2017 at 02:04:43PM +0200, Daniel Vetter wrote:
>> > On Sat, May 13, 2017 at 11:52:01AM +0100, Chris Wilson wrote:
>> > > As we can have multiple tx in the queue, with individual waiters, make
>> > > sure that all are woken when any state changes (so that we are sure the
>> > > right owner of the txmsg is woken).
>> > > 
>> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > 
>> > I think in practice we need probe vs. the userspace dp aux interface (or
>> > multiple userspace apps beating on this), and on multiple different mst
>> > sinks, but better safe than sorry.
>> 
>> Someone has to figure out what I did wrong in my remote DPCD aux_dev
>> attempt before we can actually do that:
>> 
>> [1] git://github.com/vsyrjala/linux.git dp_mst_port_aux_dev
>
> Oh, I didn't realize we don't register the full dp aux for remotes. But we
> do register the i2c for remotes, and that's good enough to blow up. i2c
> dev nodes is also more likely to be used by userspace for real (through
> the ddc tool).

Related https://bugs.freedesktop.org/show_bug.cgi?id=100954

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-15 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-13 10:52 [PATCH 1/2] drm/dp: Read the tx msg state once after checking for an event Chris Wilson
2017-05-13 10:52 ` [PATCH 2/2] drm/dp: Wait up all outstanding tx waiters Chris Wilson
2017-05-13 11:06   ` Chris Wilson
2017-05-15 12:04   ` Daniel Vetter
2017-05-15 12:33     ` [Intel-gfx] " Ville Syrjälä
2017-05-15 13:37       ` Daniel Vetter
2017-05-15 15:02         ` Jani Nikula [this message]
2017-05-13 11:18 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: Read the tx msg state once after checking for an event Patchwork
2017-05-15 12:02 ` [PATCH 1/2] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9uuduyg.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox