Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "Knop, Ryszard" <ryszard.knop@intel.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"rk@dragonic.eu" <rk@dragonic.eu>,
	"daniel@fooishbar.org" <daniel@fooishbar.org>,
	Sima Vetter <sima@ffwll.ch>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: Discussion: Moving away from Patchwork for Intel i915/Xe CI
Date: Thu, 06 Mar 2025 10:20:22 +0200	[thread overview]
Message-ID: <87pliuwoxl.fsf@intel.com> (raw)
In-Reply-To: <qiilvo4yumvostcmeehx3ifolg5e7jt5h363c4tninmttaxk4c@hpgpbwdb4e2j>

On Wed, 05 Mar 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Wed, Mar 05, 2025 at 07:52:31PM +0200, Jani Nikula wrote:
>>There's a small catch here. Patchwork is currently more clever about
>
> for some notion of clever. Try giving this kind of feedback in the
> mailing list:
>
> "oh, in addition to what you did, you also need this:
>
> ----8<----
> <diff>
> ----8<----"
>
> It will a) mangle the author for the entire series b) not do right thing
> with the patch and the series won't apply anymore (afair it tries to
> replace the patch with what you gave as diff). Also, what should go in
> the subject? Is it v{n}, v{n+1} or v{n}.1? There may be an answer, not
> documented anywhere, but for me relying on "this is what b4 does" rather
> than a specific behavior in this forked patchwork instance is much
> better.  At least with b4 we can set expectations or have hope of
> eventually tweaking it.

Agreed.

And as Konstantin noted, b4 already does better than what I claimed
(maybe I need to upgrade).


BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2025-03-06  8:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 16:51 Discussion: Moving away from Patchwork for Intel i915/Xe CI Knop, Ryszard
2025-03-05 17:30 ` Lucas De Marchi
2025-03-05 17:52 ` Jani Nikula
2025-03-05 19:33   ` Konstantin Ryabitsev
2025-03-06 10:42     ` Jani Nikula
2025-03-06 16:44       ` Konstantin Ryabitsev
2025-03-07  9:23         ` Jani Nikula
2025-03-05 19:54   ` Ryszard Knop
2025-03-06 10:48     ` Jani Nikula
2025-03-05 20:32   ` Lucas De Marchi
2025-03-06  8:20     ` Jani Nikula [this message]
2025-03-13 10:22 ` Jani Nikula
2025-03-13 10:40   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pliuwoxl.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel@fooishbar.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rk@dragonic.eu \
    --cc=ryszard.knop@intel.com \
    --cc=sima@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox