From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm/i915: Drop pointless null checks and fix a scaler bug
Date: Fri, 08 Dec 2023 11:55:51 +0200 [thread overview]
Message-ID: <87plzhyq54.fsf@intel.com> (raw)
In-Reply-To: <20231207193441.20206-1-ville.syrjala@linux.intel.com>
On Thu, 07 Dec 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Mostly just dropping a bunch of redundant null checks that I ran
> into while playing around with __attribute__((nonnull)).
>
> And I also ended up discovering an actual bug in the scaler code.
Series is
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Ville Syrjälä (8):
> drm/i915: Fix intel_atomic_setup_scalers() plane_state handling
> drm/i915: Streamline intel_dsc_pps_read()
> drm/i915: Drop redundant NULL check
> drm/i915: Drop crtc NULL check from intel_crtc_active()
> drm/i915: Drop NULL fb check from intel_fb_uses_dpt()
> drm/i915: Clean up intel_get_frame_time_us()
> drm/i915: s/cstate/crtc_state/ in intel_get_frame_time_us()
> drm/i915/tv: Drop redundant null checks
>
> drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
> drivers/gpu/drm/i915/display/intel_bios.c | 3 +--
> drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
> drivers/gpu/drm/i915/display/intel_psr.c | 6 +++---
> drivers/gpu/drm/i915/display/intel_tv.c | 6 ------
> drivers/gpu/drm/i915/display/intel_vdsc.c | 21 +++++++--------------
> drivers/gpu/drm/i915/display/skl_scaler.c | 2 +-
> 7 files changed, 14 insertions(+), 28 deletions(-)
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-12-08 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:34 [PATCH 0/8] drm/i915: Drop pointless null checks and fix a scaler bug Ville Syrjala
2023-12-07 19:34 ` [PATCH 1/8] drm/i915: Fix intel_atomic_setup_scalers() plane_state handling Ville Syrjala
2023-12-07 19:34 ` [PATCH 2/8] drm/i915: Streamline intel_dsc_pps_read() Ville Syrjala
2023-12-07 19:34 ` [PATCH 3/8] drm/i915: Drop redundant NULL check Ville Syrjala
2023-12-07 19:34 ` [PATCH 4/8] drm/i915: Drop crtc NULL check from intel_crtc_active() Ville Syrjala
2023-12-07 19:34 ` [PATCH 5/8] drm/i915: Drop NULL fb check from intel_fb_uses_dpt() Ville Syrjala
2023-12-07 19:34 ` [PATCH 6/8] drm/i915: Clean up intel_get_frame_time_us() Ville Syrjala
2023-12-07 19:34 ` [PATCH 7/8] drm/i915: s/cstate/crtc_state/ in intel_get_frame_time_us() Ville Syrjala
2023-12-07 19:34 ` [PATCH 8/8] drm/i915/tv: Drop redundant null checks Ville Syrjala
2023-12-08 1:53 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Drop pointless null checks and fix a scaler bug Patchwork
2023-12-08 2:07 ` ✓ Fi.CI.BAT: success " Patchwork
2023-12-08 9:55 ` Jani Nikula [this message]
2023-12-08 9:56 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plzhyq54.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox