From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/drv: use intel_uncore_write() for register access
Date: Thu, 27 Feb 2020 09:20:02 +0200 [thread overview]
Message-ID: <87pne0qyxp.fsf@intel.com> (raw)
In-Reply-To: <158263116471.26598.16766291631054442050@skylake-alporthouse-com>
On Tue, 25 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-02-25 11:15:09)
>> The implicit "dev_priv" local variable use has been a long-standing pain
>> point in the register access macros I915_READ(), I915_WRITE(),
>> POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
>>
>> Replace the sole remaining I915_WRITE() in i915_drv.c with
>> intel_uncore_write(), although it might be better to keep the entire
>> file void of direct register access.
>>
>> No functional changes.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_drv.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 7f0e0ba918e9..57e2fc911dac 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -758,7 +758,8 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
>> * when running inside a VM.
>> */
>> if (intel_vgpu_active(dev_priv))
>> - I915_WRITE(vgtif_reg(display_ready), VGT_DRV_DISPLAY_READY);
>> + intel_uncore_write(&dev_priv->uncore, vgtif_reg(display_ready),
>> + VGT_DRV_DISPLAY_READY);
>
> Bonus patch for intel_vgpu_register() ?
Sure!
> Series is
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed to dinq.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-27 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 11:15 [Intel-gfx] [PATCH 1/3] drm/i915: split out intel_dram.[ch] from i915_drv.c Jani Nikula
2020-02-25 11:15 ` [Intel-gfx] [PATCH 2/3] drm/i915/dram: use intel_uncore_*() functions for register access Jani Nikula
2020-02-25 11:15 ` [Intel-gfx] [PATCH 3/3] drm/i915/drv: use intel_uncore_write() " Jani Nikula
2020-02-25 11:46 ` Chris Wilson
2020-02-27 7:20 ` Jani Nikula [this message]
2020-02-25 13:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: split out intel_dram.[ch] from i915_drv.c Patchwork
2020-02-25 13:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pne0qyxp.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox