Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Squelch kerneldoc complaints
Date: Mon, 27 Jan 2020 12:09:46 +0200	[thread overview]
Message-ID: <87pnf5b47p.fsf@intel.com> (raw)
In-Reply-To: <20200126195654.2172937-1-chris@chris-wilson.co.uk>

On Sun, 26 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> drivers/gpu/drm/i915/display/intel_atomic.c:185: warning: Function parameter or member 'state' not described in 'intel_connector_needs_modeset'
> drivers/gpu/drm/i915/display/intel_atomic.c:185: warning: Function parameter or member 'connector' not described in 'intel_connector_needs_modeset'
>
> drivers/gpu/drm/i915/display/intel_fbc.c:1124: warning: Function parameter or member 'state' not described in 'intel_fbc_enable'
> drivers/gpu/drm/i915/display/intel_fbc.c:1124: warning: Excess function parameter 'crtc_state' description in 'intel_fbc_enable'
> drivers/gpu/drm/i915/display/intel_fbc.c:1124: warning: Excess function parameter 'plane_state' description in 'intel_fbc_enable'

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Arek, what does it take to enable automated documentation builds and
error reporting on CI?

>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/display/intel_atomic.c  | 2 ++
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c     | 3 +--
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
> index c362eecdd414..9921b1fa4e70 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic.c
> @@ -178,6 +178,8 @@ intel_digital_connector_duplicate_state(struct drm_connector *connector)
>  
>  /**
>   * intel_connector_needs_modeset - check if connector needs a modeset
> + * @state: the atomic state corresponding to this modeset
> + * @connector: the connector
>   */
>  bool
>  intel_connector_needs_modeset(struct intel_atomic_state *state,
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 9c81576dc43e..aaef06e19828 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -15861,7 +15861,7 @@ static void fb_obj_bump_render_priority(struct drm_i915_gem_object *obj)
>  
>  /**
>   * intel_prepare_plane_fb - Prepare fb for usage on plane
> - * @plane: drm plane to prepare for
> + * @_plane: drm plane to prepare for
>   * @_new_plane_state: the plane state being prepared
>   *
>   * Prepares a framebuffer for usage on a display plane.  Generally this
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 88a9c2fea695..d3be6f619b31 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1111,8 +1111,7 @@ void intel_fbc_choose_crtc(struct drm_i915_private *dev_priv,
>  /**
>   * intel_fbc_enable: tries to enable FBC on the CRTC
>   * @crtc: the CRTC
> - * @crtc_state: corresponding &drm_crtc_state for @crtc
> - * @plane_state: corresponding &drm_plane_state for the primary plane of @crtc
> + * @state: corresponding &drm_crtc_state for @crtc
>   *
>   * This function checks if the given CRTC was chosen for FBC, then enables it if
>   * possible. Notice that it doesn't activate FBC. It is valid to call

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-27 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 19:56 [Intel-gfx] [PATCH] drm/i915/display: Squelch kerneldoc complaints Chris Wilson
2020-01-27 10:09 ` Jani Nikula [this message]
2020-01-27 20:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Squelch kerneldoc complaints (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-01-17 10:24 [Intel-gfx] [PATCH] drm/i915/display: Squelch kerneldoc complaints Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnf5b47p.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox