From: Jani Nikula <jani.nikula@intel.com>
To: imre.deak@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/icl: Factor out combo PHY lane power setup helper
Date: Fri, 03 May 2019 09:46:15 +0300 [thread overview]
Message-ID: <87pnp0nih4.fsf@intel.com> (raw)
In-Reply-To: <20190502154507.GD22997@ideak-desk.fi.intel.com>
On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
> On Thu, May 02, 2019 at 05:45:45PM +0300, Jani Nikula wrote:
>> On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
>> > Thanks for the review, series pushed to -dinq, with the s/icl_/intel_/
>> > change and adding the headers to intel_combo_phy.h required by the
>> > recent header refactoring.
>>
>> Hey, I expected a resend. Please always resend the the rebased patches
>> for CI, and only push patches that have gone through CI!
>
> Ok, will do so.
>
> I assume though that trivial changes only in the commit message and/or
> code comments - if the reviewer has agreed to them - don't need a
> resend. That would only result in in an unecessary run through CI with
> unchanged code.
Yup.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-03 6:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 18:52 [PATCH v2 1/2] drm/i915/icl: Factor out combo PHY lane power setup helper Imre Deak
2019-04-25 18:52 ` [PATCH v2 2/2] drm/i915/icl: Add missing combo PHY lane power setup Imre Deak
2019-04-25 19:03 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/icl: Factor out combo PHY lane power setup helper Patchwork
2019-04-25 19:51 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-26 8:39 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-02 14:17 ` Imre Deak
2019-05-02 14:45 ` Jani Nikula
2019-05-02 15:45 ` Imre Deak
2019-05-03 6:46 ` Jani Nikula [this message]
2019-04-30 12:44 ` [PATCH v2 1/2] " Jani Nikula
2019-04-30 12:48 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnp0nih4.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox