public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jagadeesh Pagadala <jagdsh.linux@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch,
	joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] gpu:drm: Remove duplicate headers
Date: Thu, 28 Mar 2019 19:48:49 +0200	[thread overview]
Message-ID: <87pnqaanzy.fsf@intel.com> (raw)
In-Reply-To: <20190328190203.GA27353@CentOS76.localdomain>

On Fri, 29 Mar 2019, Jagadeesh Pagadala <jagdsh.linux@gmail.com> wrote:
> On Thu, Mar 28, 2019 at 04:12:10PM +0200, Laurent Pinchart wrote:
>> Hi Jagadeesh,
>> 
>> On Thu, Mar 28, 2019 at 09:32:06PM +0530, Jagadeesh Pagadala wrote:
>> > On Thu, Mar 28, 2019 at 08:51:24AM +0200, Laurent Pinchart wrote:
>> > > On Thu, Mar 28, 2019 at 02:41:56AM +0530, jagdsh.linux@gmail.com wrote:
>> > > > From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>> > > > 
>> > > > Remove duplicate headers which are included twice.
>> > > 
>> > > Could you, while at it, also sort the existing #include statements
>> > > alphabetically ? This should help avoiding similar issues in the future.
>> > > 
>> > > > Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>> > > > ---
>> > > >  drivers/gpu/drm/bridge/panel.c       | 1 -
>> > > >  drivers/gpu/drm/i915/intel_display.c | 7 -------
>> > > >  2 files changed, 8 deletions(-)
>> > > > 
>> > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
>> > > > index 38eeaf8..eb9567d 100644
>> > > > --- a/drivers/gpu/drm/bridge/panel.c
>> > > > +++ b/drivers/gpu/drm/bridge/panel.c
>> > > > @@ -15,7 +15,6 @@
>> > > >  #include <drm/drm_encoder.h>
>> > > >  #include <drm/drm_modeset_helper_vtables.h>
>> > > >  #include <drm/drm_probe_helper.h>
>> > > > -#include <drm/drm_panel.h>
>> > > >  
>> > > >  struct panel_bridge {
>> > > >  	struct drm_bridge bridge;
>> > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> > > > index ccb6163..1166342 100644
>> > > > --- a/drivers/gpu/drm/i915/intel_display.c
>> > > > +++ b/drivers/gpu/drm/i915/intel_display.c
>> > > > @@ -51,14 +51,7 @@
>> > > >  #include "intel_dsi.h"
>> > > >  #include "intel_frontbuffer.h"
>> > > >  
>> > > > -#include "intel_drv.h"
>> > > > -#include "intel_dsi.h"
>> > > > -#include "intel_frontbuffer.h"
>> > > > -
>> > > > -#include "i915_drv.h"
>> > > > -#include "i915_gem_clflush.h"
>> > > >  #include "i915_reset.h"
>> > > > -#include "i915_trace.h"
>> > > >  
>> > > >  /* Primary plane formats for gen <= 3 */
>> > > >  static const u32 i8xx_primary_formats[] = {
>> 
>> > From c9a68b204fe4bb013c2b8481ca8239c957dd69cc Mon Sep 17 00:00:00 2001
>> > From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>> > Date: Thu, 28 Mar 2019 21:20:12 +0530
>> > Subject: [PATCH] gpu:drm: sort the existing #includes alphabetically
>> > 
>> > Hi Laurent,
>> > 
>> > Hopefully this helps.
>> 
>> It does, thanks. If you squash it with your original patch and send a
>> v2, you can add my
>> 
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> 
>> > Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>> > ---
>> >  drivers/gpu/drm/bridge/panel.c       | 2 +-
>> >  drivers/gpu/drm/i915/intel_display.c | 4 ++--
>> >  2 files changed, 3 insertions(+), 3 deletions(-)
>> > 
>> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
>> > index eb9567d..000ba7c 100644
>> > --- a/drivers/gpu/drm/bridge/panel.c
>> > +++ b/drivers/gpu/drm/bridge/panel.c
>> > @@ -9,11 +9,11 @@
>> >   */
>> >  
>> >  #include <drm/drmP.h>
>> > -#include <drm/drm_panel.h>
>> >  #include <drm/drm_atomic_helper.h>
>> >  #include <drm/drm_connector.h>
>> >  #include <drm/drm_encoder.h>
>> >  #include <drm/drm_modeset_helper_vtables.h>
>> > +#include <drm/drm_panel.h>
>> >  #include <drm/drm_probe_helper.h>
>> >  
>> >  struct panel_bridge {
>> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> > index 1166342..7956e89 100644
>> > --- a/drivers/gpu/drm/i915/intel_display.c
>> > +++ b/drivers/gpu/drm/i915/intel_display.c
>> > @@ -46,13 +46,13 @@
>> >  
>> >  #include "i915_drv.h"
>> >  #include "i915_gem_clflush.h"
>> > +#include "i915_reset.h"
>> >  #include "i915_trace.h"
>> > +
>> >  #include "intel_drv.h"
>> >  #include "intel_dsi.h"
>> >  #include "intel_frontbuffer.h"
>> >  
>> > -#include "i915_reset.h"
>> > -
>> >  /* Primary plane formats for gen <= 3 */
>> >  static const u32 i8xx_primary_formats[] = {
>> >  	DRM_FORMAT_C8,
>> 
>> -- 
>> Regards,
>> 
>> Laurent Pinchart
> From 25776c74d289f8c2e6c89d8838f3110981ce2515 Mon Sep 17 00:00:00 2001
> From: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
> Date: Fri, 29 Mar 2019 00:04:29 +0530
> Subject: [PATCH v2] gpu:drm: Remove duplicate headers
>
> 1. Remove duplicate headers which are included twice.
> 2. Sort the existing #includes alphabetically
>
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

For further reference, please see how to use git send-email to reply to
previous versions instead of attaching. Also see 'git log --
drivers/gpu/drm' on the subject prefix; nobody uses "gpu:drm:".

Acked-by: Jani Nikula <jani.nikula@intel.com>

for merging via drm-misc


> ---
>  drivers/gpu/drm/bridge/panel.c       | 3 +--
>  drivers/gpu/drm/i915/intel_display.c | 9 +--------
>  2 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 38eeaf8..000ba7c 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -9,13 +9,12 @@
>   */
>  
>  #include <drm/drmP.h>
> -#include <drm/drm_panel.h>
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_connector.h>
>  #include <drm/drm_encoder.h>
>  #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_probe_helper.h>
>  #include <drm/drm_panel.h>
> +#include <drm/drm_probe_helper.h>
>  
>  struct panel_bridge {
>  	struct drm_bridge bridge;
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ccb6163..7956e89 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -46,20 +46,13 @@
>  
>  #include "i915_drv.h"
>  #include "i915_gem_clflush.h"
> +#include "i915_reset.h"
>  #include "i915_trace.h"
> -#include "intel_drv.h"
> -#include "intel_dsi.h"
> -#include "intel_frontbuffer.h"
>  
>  #include "intel_drv.h"
>  #include "intel_dsi.h"
>  #include "intel_frontbuffer.h"
>  
> -#include "i915_drv.h"
> -#include "i915_gem_clflush.h"
> -#include "i915_reset.h"
> -#include "i915_trace.h"
> -
>  /* Primary plane formats for gen <= 3 */
>  static const u32 i8xx_primary_formats[] = {
>  	DRM_FORMAT_C8,

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-03-28 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 21:11 [PATCH] gpu:drm: Remove duplicate headers jagdsh.linux
2019-03-28  6:41 ` Mukesh Ojha
2019-03-28  6:51 ` Laurent Pinchart
     [not found]   ` <20190328160206.GA94653@CentOS76.localdomain>
     [not found]     ` <20190328141210.GA4813@pendragon.ideasonboard.com>
2019-03-28 19:02       ` [PATCH v2] " Jagadeesh Pagadala
2019-03-28 17:48         ` Jani Nikula [this message]
2019-03-29  6:32         ` Mukesh Ojha
2019-04-02 12:19 ` ✗ Fi.CI.CHECKPATCH: warning for gpu:drm: Remove duplicate headers (rev2) Patchwork
2019-04-02 12:54 ` ✓ Fi.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnqaanzy.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jagdsh.linux@gmail.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox