From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove redundant check on execlists interrupt
Date: Thu, 08 Feb 2018 17:20:30 +0200 [thread overview]
Message-ID: <87po5fv77l.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180208151224.16285-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Since commit 4a118ecbe99c ("drm/i915: Filter out spurious execlists
> context-switch interrupts") we probe execlists->active, and no longer
> have to peek at the execlist interrupt to determine if the tasklet still
> needs to be run to drain the ELSP.
>
> References: 4a118ecbe99c ("drm/i915: Filter out spurious execlists context-switch interrupts")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index bf634432c9c6..0ad9184eba97 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1503,10 +1503,6 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine)
> if (I915_SELFTEST_ONLY(engine->breadcrumbs.mock))
> return true;
>
> - /* Interrupt/tasklet pending? */
> - if (test_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted))
> - return false;
> -
We assert that active is set on preempt so there should
be no window of idleness during that either.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> /* Waiting to drain ELSP? */
> if (READ_ONCE(engine->execlists.active))
> return false;
> --
> 2.16.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-08 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 15:12 [PATCH] drm/i915: Remove redundant check on execlists interrupt Chris Wilson
2018-02-08 15:20 ` Mika Kuoppala [this message]
2018-02-08 15:29 ` Chris Wilson
2018-02-08 15:32 ` Chris Wilson
2018-02-08 15:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-08 23:10 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po5fv77l.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox