public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH RFC] drm/i915: Print dmesg warn on unintended hangs
Date: Fri, 10 Nov 2017 14:49:25 +0200	[thread overview]
Message-ID: <87po8qqox6.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <151031702167.2124.14270441170867953359@mail.alporthouse.com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2017-11-10 12:20:55)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>> 
>> > Quoting Mika Kuoppala (2017-11-10 11:53:47)
>> >> We have a problem of distinguishing intended hangs
>> >> submitted by igt during CI/bat and hangs that are nonintended
>> >> happening in close proximity.
>> >
>> > Do we? I haven't had that problem in distinguishing them.
>> 
>> Piglit can't tell them apart afaik. Due to info level.
>
> Piglit? If the test passes, it doesn't matter how the kernel got there,
> the user behaviour is as expected. If the test wants to assert that it
> didn't hang, it can do that.

Through reset counts? At starters we could assert in framework that
all tests that do not call igt_hang() expect reset count to
stay the same between entry/exit.

I see the logic behind that user behaviour is as expected.

Would be good that CI folks chime in here and detail how
they want things to work.

-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-10 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 11:53 [PATCH RFC] drm/i915: Print dmesg warn on unintended hangs Mika Kuoppala
2017-11-10 12:16 ` Chris Wilson
2017-11-10 12:20   ` Mika Kuoppala
2017-11-10 12:30     ` Chris Wilson
2017-11-10 12:49       ` Mika Kuoppala [this message]
2017-11-10 13:21         ` Daniel Vetter
2017-11-10 12:52       ` Chris Wilson
2017-11-10 12:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-10 14:22 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po8qqox6.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox