From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/cnl: Fix LSPCON support.
Date: Wed, 16 Aug 2017 10:57:49 +0300 [thread overview]
Message-ID: <87pobwaqrm.fsf@nikula.org> (raw)
In-Reply-To: <20170816030403.11368-1-rodrigo.vivi@intel.com>
On Tue, 15 Aug 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> When LSPCON support was extended to CNL
> one part was missed on lspcon_init.
>
> So, instead of adding check per platform on lspcon_init
> let's use HAS_LSPCON that is already there for that
> purpose.
I think HAS_LSPCON will require tweaking going forward, but this is good
for now.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
> index 5abef482eacf..beb9baaf2f2e 100644
> --- a/drivers/gpu/drm/i915/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
> @@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)
> struct drm_device *dev = intel_dig_port->base.base.dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
>
> - if (!IS_GEN9(dev_priv)) {
> - DRM_ERROR("LSPCON is supported on GEN9 only\n");
> + if (!HAS_LSPCON(dev_priv)) {
> + DRM_ERROR("LSPCON is not supported on this platform\n");
> return false;
> }
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-16 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 3:04 [PATCH] drm/i915/cnl: Fix LSPCON support Rodrigo Vivi
2017-08-16 3:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-16 7:57 ` Jani Nikula [this message]
2017-08-16 10:47 ` [PATCH] " Sharma, Shashank
2017-08-16 14:50 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pobwaqrm.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).