From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✓ Fi.CI.BAT: success for drm/i915: uninitialized value on error path (rev3)
Date: Tue, 18 Apr 2017 12:38:58 +0300 [thread overview]
Message-ID: <87pogaukb1.fsf@intel.com> (raw)
In-Reply-To: <20170418091451.rkvpqggmi2kbputf@mwanda>
On Tue, 18 Apr 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Apr 18, 2017 at 10:58:44AM +0300, Jani Nikula wrote:
>> On Mon, 17 Apr 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Fri, Apr 14, 2017 at 08:13:43PM -0000, Patchwork wrote:
>> >> == Series Details ==
>> >>
>> >> Series: drm/i915: uninitialized value on error path (rev3)
>> >> URL : https://patchwork.freedesktop.org/series/23038/
>> >> State : success
>> >
>> > These patchwork emails are sort of useless. I wouldn't have sent the
>> > patch if it couldn't compile which is basically all this is testing.
>> > It's not exercising the failure path.
>>
>> Yeah, the CI is not smart enough to know that just by looking at the
>> patch, so it'll test them all. ;)
>>
>
> But could it just send responses if something fails? Or it could be a
> much shorter email:
>
> CI test successful.
>
> Use X-mailer-blahblah to filter successful tests.
>
> We don't need to expose all the other internal information unless
> something fails.
Thanks, I passed on the feedback.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-18 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 19:53 [PATCH] drm/i915: uninitialized value on error path Dan Carpenter
2017-04-13 20:29 ` Chris Wilson
2017-04-13 21:13 ` Dan Carpenter
2017-04-14 19:54 ` [PATCH v2] drm/i915: set "ret" correctly on error paths Dan Carpenter
2017-04-15 9:32 ` Chris Wilson
2017-04-13 20:44 ` ✓ Fi.CI.BAT: success for drm/i915: uninitialized value on error path Patchwork
2017-04-14 20:13 ` ✓ Fi.CI.BAT: success for drm/i915: uninitialized value on error path (rev3) Patchwork
2017-04-17 10:53 ` Dan Carpenter
2017-04-18 7:58 ` Jani Nikula
2017-04-18 9:14 ` Dan Carpenter
2017-04-18 9:38 ` Jani Nikula [this message]
2017-04-18 10:35 ` Martin Peres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pogaukb1.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox