From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Conselvan De Oliveira, Ander" <ander.conselvan.de.oliveira@intel.com>
Subject: Re: [PATCH] drm/i915: fix sparse warning for using false as NULL
Date: Wed, 16 Mar 2016 18:14:00 +0200 [thread overview]
Message-ID: <87pouu7647.fsf@intel.com> (raw)
In-Reply-To: <1458144418-20046-1-git-send-email-jani.nikula@intel.com>
On Wed, 16 Mar 2016, Jani Nikula <jani.nikula@intel.com> wrote:
> drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer as NULL pointer
>
> Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c")
Forgot to Cc: Ander on this one.
BR,
Jani.
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 74d5aecc0be5..e53d57c39056 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -1197,7 +1197,7 @@ skl_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
> ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
>
> if (!skl_ddi_calculate_wrpll(clock * 1000, &wrpll_params))
> - return false;
> + return NULL;
>
> cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
> DPLL_CFGCR1_DCO_FRACTION(wrpll_params.dco_fraction) |
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-16 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 16:06 [PATCH] drm/i915: fix sparse warning for using false as NULL Jani Nikula
2016-03-16 16:14 ` Jani Nikula [this message]
2016-03-16 16:16 ` Ville Syrjälä
2016-03-17 9:35 ` Jani Nikula
2016-03-17 8:01 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pouu7647.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox