Re: [Intel-gfx] [PATCH 0/7] Enable YCbCr420 format for VDSC

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 08 Mar 2023, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:
> On 08/03/2023 13:30, Jani Nikula wrote:
>> On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
>>> This patch series aims to enable the YCbCr420 format
>>> for DSC. Changes are mostly compute params related for
>>> hdmi,dp and dsi along with the addition of new rc_tables
>>> for native_420 and corresponding changes to macros used to
>>> fetch them.
>>> There have been discussions prior to this series in which some patches
>>> have gotten rb and can be found in the below link
>>> https://patchwork.freedesktop.org/series/113729
>> 
>> I think it would be useful to get [1] from Dmitry merged to
>> drm-misc-next first, have that in drm-next, and again backmerged to
>> drm-intel-next before this. At least patches 1-5.
>> 
>> There's not much point in all drivers duplicating the parameters, and we
>> need to move towards common code. Dmitry has been helpful in
>> contributing this to us.
>
> Note, while I slightly reworked the calculate_rc_params() function, I 
> did not touch the intel_qp_tables (mostly since we do not need them for 
> drm/msm (at least for now). Our current plan is to use fixed params (at 
> least in the short notice). We might have to reconsider it at some point.

Yeah, this isn't a big conflict, but AFAICT it'll conflict in
intel_vdsc.c.

> However it might be wise to merge them with amdgpu's qp tables. amdgpu 
> driver also contains code to calculate RC params. It might be worth 
> moving RC calculation to the common helper.

Agreed.

BR,
Jani.


>
>> 
>> BR,
>> Jani.
>> 
>> 
>> [1] https://patchwork.freedesktop.org/series/114473/
>> 
>>>
>>> Ankit Nautiyal (2):
>>>    drm/dp_helper: Add helper to check DSC support with given o/p format
>>>    drm/i915/dp: Check if DSC supports the given output_format
>>>
>>> Suraj Kandpal (4):
>>>    drm/i915: Adding the new registers for DSC
>>>    drm/i915: Enable YCbCr420 for VDSC
>>>    drm/i915/display: Fill in native_420 field
>>>    drm/i915/vdsc: Check slice design requirement
>>>
>>> Swati Sharma (1):
>>>    drm/i915/dsc: Add debugfs entry to validate DSC output formats
>>>
>>>   drivers/gpu/drm/i915/display/icl_dsi.c        |   2 -
>>>   .../drm/i915/display/intel_crtc_state_dump.c  |   4 +-
>>>   .../drm/i915/display/intel_crtc_state_dump.h  |   2 +
>>>   .../drm/i915/display/intel_display_debugfs.c  |  78 ++++++++
>>>   .../drm/i915/display/intel_display_types.h    |   1 +
>>>   drivers/gpu/drm/i915/display/intel_dp.c       |  39 +++-
>>>   .../gpu/drm/i915/display/intel_qp_tables.c    | 187 ++++++++++++++++--
>>>   .../gpu/drm/i915/display/intel_qp_tables.h    |   4 +-
>>>   drivers/gpu/drm/i915/display/intel_vdsc.c     | 108 +++++++++-
>>>   drivers/gpu/drm/i915/i915_reg.h               |  28 +++
>>>   include/drm/display/drm_dp_helper.h           |  13 ++
>>>   11 files changed, 442 insertions(+), 24 deletions(-)
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center