Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus LPT iCLKIP WARN

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 16 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The WARN shouldn't have been added yet. For the moment the
> clock that gets passed here is just what the user has requested
> (via the modeline) and may not be exactly what iCLKIP can
> generate.
>
> Later on the plan is to change things so that we already get
> passed the exact clock here, at which point the WARN should
> be reintroduced.

Hmph, who reviwed that patch anyway?!

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6246
> Fixes: 97708335b04d ("drm/i915: Introduce struct iclkip_params")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_pch_refclk.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> index 752dab11667f..9934c8a9e240 100644
> --- a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> @@ -179,7 +179,6 @@ void lpt_program_iclkip(const struct intel_crtc_state *crtc_state)
>  	lpt_disable_iclkip(dev_priv);
>  
>  	lpt_compute_iclkip(&p, clock);
> -	drm_WARN_ON(&dev_priv->drm, lpt_iclkip_freq(&p) != clock);
>  
>  	/* This should not happen with any sane values */
>  	drm_WARN_ON(&dev_priv->drm, SBI_SSCDIVINTPHASE_DIVSEL(p.divsel) &

-- 
Jani Nikula, Intel Open Source Graphics Center