From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Warn if rps max frequency is not set
Date: Tue, 20 Mar 2018 18:28:20 +0200 [thread overview]
Message-ID: <87r2oe67a3.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180320151734.11761-2-mika.kuoppala@linux.intel.com>
Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:
> Warn on enabling rps when our hw max is invalid.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 19e82aaa9863..bc335c52a17a 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8157,6 +8157,8 @@ static void intel_enable_rps(struct drm_i915_private *dev_priv)
> intel_init_emon(dev_priv);
> }
>
> + WARN_ON(rps->max_freq == 0);
> +
Ok, this wont fly with gen < 6
-Mika
> WARN_ON(rps->max_freq < rps->min_freq);
> WARN_ON(rps->idle_freq > rps->max_freq);
>
> --
> 2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-20 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 15:17 [PATCH 1/2] drm/i915: Avoid setting ring freq on invalid rps freqs Mika Kuoppala
2018-03-20 15:17 ` [PATCH 2/2] drm/i915: Warn if rps max frequency is not set Mika Kuoppala
2018-03-20 16:28 ` Mika Kuoppala [this message]
2018-03-20 18:01 ` Chris Wilson
2018-03-20 15:56 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Avoid setting ring freq on invalid rps freqs Patchwork
2018-03-22 21:36 ` [PATCH 1/2] " Chris Wilson
2018-03-23 10:00 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2oe67a3.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox