Re: [Intel-gfx] [PATCH] drm/i915: Fix mistake in intel_modeset_all_pipes condition

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 09 Aug 2023, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
> It is supposed to be "!intel_crtc_needs_modeset" - otherwise,
> we are active exactly vice versa for active pipes: skipping if modeset
> is needed and not skipping if not needed.

If the crtc *already* needs a full modeset, there's no need to force a
modeset on it.

BR,
Jani.

>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 763ab569d8f32..4b1d7034078ca 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5439,7 +5439,7 @@ int intel_modeset_all_pipes(struct intel_atomic_state *state,
>  			return PTR_ERR(crtc_state);
>  
>  		if (!crtc_state->hw.active ||
> -		    intel_crtc_needs_modeset(crtc_state))
> +		    !intel_crtc_needs_modeset(crtc_state))
>  			continue;
>  
>  		drm_dbg_kms(&dev_priv->drm, "[CRTC:%d:%s] Full modeset due to %s\n",

-- 
Jani Nikula, Intel Open Source Graphics Center