From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: remove superfluous string helper include
Date: Tue, 03 May 2022 10:52:49 +0300 [thread overview]
Message-ID: <87sfprqcha.fsf@intel.com> (raw)
In-Reply-To: <Ymbxvoay8QqjdVP+@mdroper-desk1.amr.corp.intel.com>
On Mon, 25 Apr 2022, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Mon, Apr 25, 2022 at 06:47:54PM +0300, Jani Nikula wrote:
>> Remove the duplicate and incorrect (uses "" instead of <>)
>> linux/string_helpers.h include.
>>
>> Fixes: cc1338f259a2 ("drm/i915/xehp: Update topology dumps for Xe_HP")
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Thanks, pushed to drm-intel-gt-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/gt/intel_sseu.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
>> index 9881a6790574..fdd25691beda 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_sseu.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
>> @@ -10,8 +10,6 @@
>> #include "intel_gt_regs.h"
>> #include "intel_sseu.h"
>>
>> -#include "linux/string_helpers.h"
>> -
>> void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices,
>> u8 max_subslices, u8 max_eus_per_subslice)
>> {
>> --
>> 2.30.2
>>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-05-03 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 15:47 [Intel-gfx] [PATCH] drm/i915: remove superfluous string helper include Jani Nikula
2022-04-25 17:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-04-25 19:08 ` [Intel-gfx] [PATCH] " Matt Roper
2022-05-03 7:52 ` Jani Nikula [this message]
2022-04-26 7:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove superfluous string helper include (rev2) Patchwork
2022-04-29 14:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove superfluous string helper include (rev3) Patchwork
2022-05-02 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove superfluous string helper include (rev4) Patchwork
2022-05-03 0:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfprqcha.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox